Closed Bug 1451820 Opened 6 years ago Closed 6 years ago

Unicode filenames and Unicode hostnames(converted from Punycode) cannot be searched in the "Filter URLs" input in the Network Monitor.

Categories

(DevTools :: Netmonitor, enhancement, P3)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: zjz, Assigned: zjz)

Details

Attachments

(4 files, 2 obsolete files)

Unicode filenames cannot be searched in the "Filter URLs" input in the Network Monitor.
Attached image 1.png
Attached image 2.png
I would like to fix this bug, could you assign this to me? Thanks!
Flags: needinfo?(odvarko)
(In reply to Zhang Junzhi from comment #3)
> I would like to fix this bug, could you assign this to me? Thanks!
Done!

Honza
Assignee: nobody → zjz
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(odvarko)
Priority: -- → P3
Summary: Unicode filenames cannot be searched in the "Filter URLs" input in the Network Monitor. → Unicode filenames and Unicode hostnames(converted from Punycode) cannot be searched in the "Filter URLs" input in the Network Monitor.
Attachment #8967941 - Attachment is obsolete: true
Attachment #8967941 - Flags: review?(odvarko)
Comment on attachment 8967941 [details]
Bug 1451820 - Part 2: Updates mochitest for Part 1.

https://reviewboard.mozilla.org/r/236634/#review242410


Code analysis found 3 defects in this patch:
 - 3 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/netmonitor/test/browser_net_filter-01.js:21
(Diff revision 1)
>   */
>  const BASIC_REQUESTS = [
> -  { url: "sjs_content-type-test-server.sjs?fmt=html&res=undefined&text=Sample" },
> +  { url: getSjsURLInUnicodeIdn() + "?fmt=html&res=undefined&text=Sample" },
>    { url: "sjs_content-type-test-server.sjs?fmt=css&text=sample" },
>    { url: "sjs_content-type-test-server.sjs?fmt=js&text=sample" },
> +  { url: `sjs_content-type-test-server.sjs?fmt=html&text=${ENCODED_UNICODE_IN_URI_COMPONENT}` },

Error: Line 21 exceeds the maximum line length of 90. [eslint: max-len]

::: devtools/client/netmonitor/test/browser_net_filter-01.js:22
(Diff revision 1)
>  const BASIC_REQUESTS = [
> -  { url: "sjs_content-type-test-server.sjs?fmt=html&res=undefined&text=Sample" },
> +  { url: getSjsURLInUnicodeIdn() + "?fmt=html&res=undefined&text=Sample" },
>    { url: "sjs_content-type-test-server.sjs?fmt=css&text=sample" },
>    { url: "sjs_content-type-test-server.sjs?fmt=js&text=sample" },
> +  { url: `sjs_content-type-test-server.sjs?fmt=html&text=${ENCODED_UNICODE_IN_URI_COMPONENT}` },
> +  { url: `sjs_content-type-test-server.sjs?fmt=css&text=${ENCODED_UNICODE_IN_URI_COMPONENT}` },

Error: Line 22 exceeds the maximum line length of 90. [eslint: max-len]

::: devtools/client/netmonitor/test/browser_net_filter-01.js:23
(Diff revision 1)
> -  { url: "sjs_content-type-test-server.sjs?fmt=html&res=undefined&text=Sample" },
> +  { url: getSjsURLInUnicodeIdn() + "?fmt=html&res=undefined&text=Sample" },
>    { url: "sjs_content-type-test-server.sjs?fmt=css&text=sample" },
>    { url: "sjs_content-type-test-server.sjs?fmt=js&text=sample" },
> +  { url: `sjs_content-type-test-server.sjs?fmt=html&text=${ENCODED_UNICODE_IN_URI_COMPONENT}` },
> +  { url: `sjs_content-type-test-server.sjs?fmt=css&text=${ENCODED_UNICODE_IN_URI_COMPONENT}` },
> +  { url: `sjs_content-type-test-server.sjs?fmt=js&text=${ENCODED_UNICODE_IN_URI_COMPONENT}` },

Error: Line 23 exceeds the maximum line length of 90. [eslint: max-len]
Comment on attachment 8967942 [details]
Bug 1451820 - Part 2: Updates mochitest for Part 1.

https://reviewboard.mozilla.org/r/236636/#review242414


Code analysis found 3 defects in this patch:
 - 3 defects found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: devtools/client/netmonitor/test/browser_net_filter-01.js:21
(Diff revision 1)
>   */
>  const BASIC_REQUESTS = [
> -  { url: "sjs_content-type-test-server.sjs?fmt=html&res=undefined&text=Sample" },
> +  { url: getSjsURLInUnicodeIdn() + "?fmt=html&res=undefined&text=Sample" },
>    { url: "sjs_content-type-test-server.sjs?fmt=css&text=sample" },
>    { url: "sjs_content-type-test-server.sjs?fmt=js&text=sample" },
> +  { url: `sjs_content-type-test-server.sjs?fmt=html&text=${ENCODED_UNICODE_IN_URI_COMPONENT}` },

Error: Line 21 exceeds the maximum line length of 90. [eslint: max-len]

::: devtools/client/netmonitor/test/browser_net_filter-01.js:22
(Diff revision 1)
>  const BASIC_REQUESTS = [
> -  { url: "sjs_content-type-test-server.sjs?fmt=html&res=undefined&text=Sample" },
> +  { url: getSjsURLInUnicodeIdn() + "?fmt=html&res=undefined&text=Sample" },
>    { url: "sjs_content-type-test-server.sjs?fmt=css&text=sample" },
>    { url: "sjs_content-type-test-server.sjs?fmt=js&text=sample" },
> +  { url: `sjs_content-type-test-server.sjs?fmt=html&text=${ENCODED_UNICODE_IN_URI_COMPONENT}` },
> +  { url: `sjs_content-type-test-server.sjs?fmt=css&text=${ENCODED_UNICODE_IN_URI_COMPONENT}` },

Error: Line 22 exceeds the maximum line length of 90. [eslint: max-len]

::: devtools/client/netmonitor/test/browser_net_filter-01.js:23
(Diff revision 1)
> -  { url: "sjs_content-type-test-server.sjs?fmt=html&res=undefined&text=Sample" },
> +  { url: getSjsURLInUnicodeIdn() + "?fmt=html&res=undefined&text=Sample" },
>    { url: "sjs_content-type-test-server.sjs?fmt=css&text=sample" },
>    { url: "sjs_content-type-test-server.sjs?fmt=js&text=sample" },
> +  { url: `sjs_content-type-test-server.sjs?fmt=html&text=${ENCODED_UNICODE_IN_URI_COMPONENT}` },
> +  { url: `sjs_content-type-test-server.sjs?fmt=css&text=${ENCODED_UNICODE_IN_URI_COMPONENT}` },
> +  { url: `sjs_content-type-test-server.sjs?fmt=js&text=${ENCODED_UNICODE_IN_URI_COMPONENT}` },

Error: Line 23 exceeds the maximum line length of 90. [eslint: max-len]
Attachment #8967942 - Attachment is obsolete: true
Attachment #8967942 - Flags: review?(odvarko)
@Zhang: How can I test the patch, do you have a test page I could use?

Honza
Flags: needinfo?(zjz)
This can be used to test for filtering a Unicode domain name:

http://nic.世界/

And this can be used to test for filtering a Unicode pathname:

https://zh.wikipedia.org/wiki/火狐
Flags: needinfo?(zjz)
Comment on attachment 8967940 [details]
Bug 1451820 - Part 1: Adds support for Unicode URI and Unicode hostname filtering in the Network Monitor.

https://reviewboard.mozilla.org/r/236632/#review242916

Works for me, thanks for the patch!

R+

Honza
Attachment #8967940 - Flags: review?(odvarko) → review+
Comment on attachment 8967943 [details]
Bug 1451820 - Part 2: Updates mochitest for Part 1.

https://reviewboard.mozilla.org/r/236638/#review242918

Looks reasonable.

R+

Thanks for working on this bug!
Honza
Attachment #8967943 - Flags: review?(odvarko) → review+
Thank you for the review
Keywords: checkin-needed
Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82f8237f91df
Part 1: Adds support for Unicode URI and Unicode hostname filtering in the Network Monitor. r=Honza
https://hg.mozilla.org/integration/autoland/rev/294df035b797
Part 2: Updates mochitest for Part 1. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/82f8237f91df
https://hg.mozilla.org/mozilla-central/rev/294df035b797
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.