Move old-frontend code in a devtools/client/webconsole/old/ folder and move everything in devtools/client/webconsole/new-console-output one level up

RESOLVED FIXED in Firefox 61

Status

enhancement
P1
normal
RESOLVED FIXED
Last year
Last year

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Tracking

(Blocks 1 bug)

Trunk
Firefox 61
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(2 attachments)

This will prepare the work of completely delete the old frontend code when we are ready to do so.
Also, this might avoid confusion for "external" contributors (not familiar with webconsole code) and prevent modifications on the old frontend.
Assignee

Updated

Last year
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: -- → P1
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

Last year
mozreview-review
Comment on attachment 8965743 [details]
Bug 1451821 - Put console old-frontend code in webconsole/old; .

https://reviewboard.mozilla.org/r/234584/#review240232

LGTM!

::: devtools/client/webconsole/old/moz.build:17
(Diff revision 1)
> +DevToolsModules(
> +    'console-output.js',
> +    'webconsole.js',
> +)
> +with Files('**'):
> +    BUG_COMPONENT = ('Firefox', 'Developer Tools: Console')

Not necessarily needed since the parent moz.build defines the same BUG_COMPONENT
(but doesn't hurt either)
Attachment #8965743 - Flags: review?(jdescottes) → review+
Joel: this patch is moving around all the tests under devtools/client/webconsole, which are referenced in https://searchfox.org/mozilla-central/source/testing/runtimes/mochitest-devtools-chrome.runtimes.json and https://searchfox.org/mozilla-central/source/testing/runtimes/mochitest-devtools-chrome-e10s.runtimes.json . 

What do you advise here, should we modify the files by hand or somehow regenerate them?
Flags: needinfo?(jmaher)
I would recommend moving the code, we will update the test runtime files a bit later this month
Flags: needinfo?(jmaher)
(In reply to Julian Descottes [:jdescottes][:julian] from comment #4)
> Comment on attachment 8965744 [details]
> Bug 1451821 - Move new-console-output content one folder up; .
> 
> https://reviewboard.mozilla.org/r/234586/#review240228
> 
> LGTM!
> 
> A few spots to update:
> - docs/tools/http-inspector.md has references to
> devtools/client/webconsole/net/

Updated

> -
> https://searchfox.org/mozilla-central/rev/
> d0413b711da4dac72b237d0895daba2537f1514c/devtools/server/tests/unit/
> test_objectgrips-21.js#84

The test have been migrated to the new frontend, and we still test CPOW. So I think we can let it as is.

> -
> https://searchfox.org/mozilla-central/rev/
> d0413b711da4dac72b237d0895daba2537f1514c/devtools/.eslintrc.js#267

done

> -
> https://searchfox.org/mozilla-central/rev/
> d0413b711da4dac72b237d0895daba2537f1514c/devtools/client/webconsole/net/test/
> unit/test_net-utils.js#54
> 

done

---

> I would recommend moving the code, we will update the test runtime files a bit later this month

I'll move on and land this patch then
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 11

Last year
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f2dd66c6d54
Put console old-frontend code in webconsole/old; r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/2e1f25c13ca3
Move new-console-output content one folder up; r=jdescottes.

Comment 12

Last year
bugherder
https://hg.mozilla.org/mozilla-central/rev/7f2dd66c6d54
https://hg.mozilla.org/mozilla-central/rev/2e1f25c13ca3
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61

Updated

Last year
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.