use SkCanvas layer clip image for DrawTargetSkia::PushLayer mask

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P1
normal
RESOLVED FIXED
a year ago
8 months ago

People

(Reporter: lsalzman, Assigned: lsalzman)

Tracking

({feature})

56 Branch
mozilla61
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Skia has had its clip image support in SkCanvas layers stabilized for a while. Using this allows us to get rid of old hacks I had made to DrawTargetSkia, and also allows me to remove several custom patches to moz-skia that were needed to make my hacks work. Less stuff for me to maintain and brings us closer to Skia trunk.
Attachment #8965429 - Flags: review?(jmuizelaar)
Comment on attachment 8965429 [details] [diff] [review]
use SkCanvas layer clip image for DrawTargetSkia::PushLayer mask

Review of attachment 8965429 [details] [diff] [review]:
-----------------------------------------------------------------

That's a refreshing patch!
Attachment #8965429 - Flags: review?(jmuizelaar) → review+

Comment 2

a year ago
Pushed by lsalzman@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2daf28697874
use SkCanvas layer clip image for DrawTargetSkia::PushLayer mask. r=jrmuizel

Comment 3

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2daf28697874
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
(Assignee)

Updated

8 months ago
Depends on: 1489632
You need to log in before you can comment on or make changes to this bug.