Closed Bug 1451864 Opened 2 years ago Closed 2 years ago

Remember logins and passwords for websites is named poorly

Categories

(Firefox :: Preferences, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: mkaply, Assigned: mkohler, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

Currently in preferences, we have a checkbox that says:

"Remember logins and passwords for websites"

But that's not actually what it does. Checking that box causes Firefox to offer to save logins and passwords, and when you uncheck it, it doesn't offer.

It should be renamed to convey what it actually does. Maybe:

"Offer to save logins and passwords for websites"

As it exists today, it implies we remember passwords and logins without user intervention.
Meridel, what do you think about this change?
Flags: needinfo?(mwalkington)
Hi - thanks for pointing this out - let's use Ask to be consistent with other parts of preferences:

Ask to save logins and passwords for websites
Flags: needinfo?(mwalkington)
Flod is maintaining the migrations, redirecting the question to him.
Flags: needinfo?(gandalf) → needinfo?(francesco.lodolo)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #3)
> zibi, does
> https://searchfox.org/mozilla-central/rev/
> b55e1a1cbcaee34878e133fbac20c4c2af6e11b5/python/l10n/fluent_migrations/
> bug_1446180_preferences_privacy.py#49 need to get updated too?

No need to touch the migration.

Depending on when this bug will be fixed, we might actually need to keep around the old string. If that's not the case, I'll clean up the migration as soon as needed.
Flags: needinfo?(francesco.lodolo)
Assignee: nobody → me
Rename 'Remember logins and passwords for websites' to 'Ask to save logins and passwords for website'
Comment on attachment 8967466 [details]
Bug 1451864 - Rename 'Remember logins and passwords for websites' to 'Ask to save logins and passwords for website' r=jaws

Francesco Lodolo [:flod] has approved the revision.

https://phabricator.services.mozilla.com/D926
Attachment #8967466 - Flags: review+
Comment on attachment 8967466 [details]
Bug 1451864 - Rename 'Remember logins and passwords for websites' to 'Ask to save logins and passwords for website' r=jaws

Jared Wein [:jaws] (please needinfo? me) has approved the revision.

https://phabricator.services.mozilla.com/D926
Attachment #8967466 - Flags: review+
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e48058b5e3cf
Rename 'Remember logins and passwords for websites' to 'Ask to save logins and passwords for website' r=jaws,flod
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/e48058b5e3cf
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.