1451874 - about:config pref layout.css.prefixes.gradients doesn't work anymore (-moz-linear-gradient is accepted regardless of pref setting)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

STR:
 1. Set about:config pref layout.css.prefixes.gradients = false
 2. Load attached testcase

EXPECTED RESULTS:
Lime background. (The -moz-linear-gradient should be rejected.)

ACTUAL RESULTS:
Red/pink gradient background.


Apparently we accept -moz-linear-gradient regardless of the pref setting now. I'm guessing this is a stylo regression.


(This bug makes it hard to experiment with removing support for moz-prefixed gradients, e.g. in bug 1182775.)

Comment 1

[Xidorn Quan [:xidorn] UTC+11]

Quite possible a stylo regression.

We should check layout_css_prefixes_gradients around Gradient::parse[1].

There should probably be some test catching that...


[1] https://searchfox.org/mozilla-central/rev/2ce99e8054b0ff6ed1adf484aeaacacf2fea084c/servo/components/style/values/specified/image.rs#181-226

Comment 2

[Emilio Cobos Álvarez (:emilio)]

yeah, let's fix this, I'd love to get rid of the -moz- gradients.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1451874: Respect the -moz- gradient pref again.

Review commit: https://reviewboard.mozilla.org/r/234744/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234744/

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 8965957 [details]
Bug 1451874: Respect the -moz- gradient pref again.

https://reviewboard.mozilla.org/r/234744/#review240414

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a41976b9334f
Respect the -moz- gradient pref again. r=xidorn

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a41976b9334f

Comment 7

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 61.0a1 (2018-04-06) on Windows 10, 64 Bit!
This bug's fix is verified with latest Beta!

Builf ID   : 20180528091514
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0