Closed
Bug 1451956
Opened 6 years ago
Closed 6 years ago
servo_function_signatures test should check the generated bindings.rs rather than the in-tree one
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: xidorn, Assigned: bholley)
References
Details
Attachments
(1 file)
2.16 KB,
patch
|
xidorn
:
review+
|
Details | Diff | Splinter Review |
We currently reads the in-tree bindings.rs, but we should really change it to use the generated bindings.rs like what we do for structs.rs later in the same file.
Assignee | ||
Comment 1•6 years ago
|
||
MozReview-Commit-ID: A7sWaD2PInN
Attachment #8968985 -
Flags: review?(xidorn+moz)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → bobbyholley
Reporter | ||
Updated•6 years ago
|
Attachment #8968985 -
Flags: review?(xidorn+moz) → review+
Pushed by bholley@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/cabd679ad5c6 Switch stylo function signature checking to use generated bindings. r=xidorn
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cabd679ad5c6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•