Closed Bug 1452010 Opened 2 years ago Closed 2 years ago

Remove nsIDOMDOMException

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

No description provided.
MozReview-Commit-ID: K5zUjh25WJG
Attachment #8965669 - Flags: review?(kyle)
MozReview-Commit-ID: Bp5ablEtcHA
Attachment #8965670 - Flags: review?(kyle)
MozReview-Commit-ID: AFKzyxCyriJ
Attachment #8965671 - Flags: review?(kyle)
MozReview-Commit-ID: K5zUjh25WJG
Attachment #8965674 - Flags: review?(kyle)
Attachment #8965669 - Attachment is obsolete: true
Attachment #8965669 - Flags: review?(kyle)
Attachment #8965670 - Flags: review?(kyle) → review+
Comment on attachment 8965674 [details] [diff] [review]
part 1.  Remove uses of nsIDOMDOMException

Review of attachment 8965674 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/server/actors/call-watcher.js
@@ +621,5 @@
>    let parsedStack = parseStack(stack);
>    let { fileName, lineNumber, columnNumber } = parsedStack[parsedStack.length - 1];
>    let error;
>  
> +  let isDOMException = ChromeUtils.getClassName(e) == "DOMException";

===

::: devtools/server/actors/object/previewers.js
@@ +732,5 @@
>      return true;
>    },
>  
>    function DOMException({obj, hooks}, grip, rawObj) {
> +    if (isWorker || !rawObj || obj.class != "DOMException") {

!==
Attachment #8965674 - Flags: review?(kyle) → review+
Attachment #8965671 - Flags: review?(kyle) → review+
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e52e0d29bb1a
part 1.  Remove uses of nsIDOMDOMException.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b4a43745b4a
part 2.  Remove nsIDOMDOMException members.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/ace85b988b45
part 3.  Remove nsIDOMDOMException.  r=qdot
https://hg.mozilla.org/mozilla-central/rev/e52e0d29bb1a
https://hg.mozilla.org/mozilla-central/rev/0b4a43745b4a
https://hg.mozilla.org/mozilla-central/rev/ace85b988b45
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.