Closed
Bug 1452010
Opened 5 years ago
Closed 5 years ago
Remove nsIDOMDOMException
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 1 obsolete file)
12.06 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
7.52 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
4.60 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
No description provided.
![]() |
Assignee | |
Comment 1•5 years ago
|
||
MozReview-Commit-ID: K5zUjh25WJG
Attachment #8965669 -
Flags: review?(kyle)
![]() |
Assignee | |
Comment 2•5 years ago
|
||
MozReview-Commit-ID: Bp5ablEtcHA
Attachment #8965670 -
Flags: review?(kyle)
![]() |
Assignee | |
Comment 3•5 years ago
|
||
MozReview-Commit-ID: AFKzyxCyriJ
Attachment #8965671 -
Flags: review?(kyle)
![]() |
Assignee | |
Comment 4•5 years ago
|
||
MozReview-Commit-ID: K5zUjh25WJG
Attachment #8965674 -
Flags: review?(kyle)
![]() |
Assignee | |
Updated•5 years ago
|
Attachment #8965669 -
Attachment is obsolete: true
Attachment #8965669 -
Flags: review?(kyle)
Updated•5 years ago
|
Attachment #8965670 -
Flags: review?(kyle) → review+
Comment 5•5 years ago
|
||
Comment on attachment 8965674 [details] [diff] [review] part 1. Remove uses of nsIDOMDOMException Review of attachment 8965674 [details] [diff] [review]: ----------------------------------------------------------------- ::: devtools/server/actors/call-watcher.js @@ +621,5 @@ > let parsedStack = parseStack(stack); > let { fileName, lineNumber, columnNumber } = parsedStack[parsedStack.length - 1]; > let error; > > + let isDOMException = ChromeUtils.getClassName(e) == "DOMException"; === ::: devtools/server/actors/object/previewers.js @@ +732,5 @@ > return true; > }, > > function DOMException({obj, hooks}, grip, rawObj) { > + if (isWorker || !rawObj || obj.class != "DOMException") { !==
Attachment #8965674 -
Flags: review?(kyle) → review+
Updated•5 years ago
|
Attachment #8965671 -
Flags: review?(kyle) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e52e0d29bb1a part 1. Remove uses of nsIDOMDOMException. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/0b4a43745b4a part 2. Remove nsIDOMDOMException members. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/ace85b988b45 part 3. Remove nsIDOMDOMException. r=qdot
Comment 7•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e52e0d29bb1a https://hg.mozilla.org/mozilla-central/rev/0b4a43745b4a https://hg.mozilla.org/mozilla-central/rev/ace85b988b45
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•4 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•