1452016 - Firefox should also have option to select images from gallery

Status: RESOLVED INACTIVE

(Firefox for Android Graveyard :: General, defect)

Description

[gautam.nishchal]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:59.0) Gecko/20100101 Firefox/59.0
Build ID: 20180326160923

Steps to reproduce:

I added a form: http://jsbin.com/vasuyogeqo/1/edit?html,output (quick link), if you want to do it yourself, any html doc with: `<input type="file" accept="image/*" />`

Opened Firefox for Android and went to: http://jsbin.com/vasuyogeqo/1 clicked on browse files.



Actual results:

It allowed me to either open camera, or went for my files


Expected results:

I should also add an option to select image from gallery.

It's not a huge problem, but a tiny thing to make user a tiny bit happy without them realizing that.

Comment 1

[Jan Henning [:JanH]]

Attachment: documents_file_picker.png

What phone model and Android version are you using?

If I'm choosing the Documents option, the file picker that gets shown
a) already has a built-in "Images" section
b) additionally offers any other apps I might have that are suitable for that mime type, including any gallery app I might have on my phone (e.g. Google Photos and Quickpic in the attached screenshot)?

Is that not working for you?

Comment 2

[gautam.nishchal]

Did you compare with chrome? that option is hidden and can't be expected as a viable option. I'm on moto z2 play I think.

Comment 3

[Jan Henning [:JanH]]

I see what you mean, but unfortunately I don't think there currently are the resources to copy that approach and write our own custom image picker UI.

Comment 4

[gautam.nishchal]

Hi, I don't mean to add a Image picker UI. I mean to trigger gallery from firefox (that's no UI picker, just intent for result or something like that, and wait for gallery to give image back), reason being it's really easy to find stuff on user's gallery than using downloads or files to navigate)

Comment 5

[Jan Henning [:JanH]]

They *are* using a custom picker UI for photos:
https://cs.chromium.org/chromium/src/ui/android/java/src/org/chromium/ui/base/SelectFileDialog.java?l=223&rcl=d6bb2dcc13ac5d402d5f3bbcf8106cd3f2c7f1f0
https://bugs.chromium.org/p/chromium/issues/detail?id=656015

And other than that, as I said above the OS file picker already allows you to switch to whatever other apps are appropriate for that respective file type, which in the case of images will include any gallery apps you might have installed.

Comment 6

[Firefox Bug Husbandry Bot]

Closing per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Contact :susheel if you think this bug should be re-opened