Closed Bug 1452019 Opened 3 years ago Closed 3 years ago

tab_selected doesn't work unless there's a headerURL

Categories

(WebExtensions :: Themes, defect, P1)

Product:
WebExtensions
Component:
Themes
Type:
defect

Tracking

(firefox59 unaffected, firefox60 fixed, firefox61 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox59 --- unaffected
firefox60 --- fixed
firefox61 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(1 file)

Bug 1452019 - Fix tab_selected when lwt-image attribute is not set.
59 bytes, text/x-review-board-request
jaws
: review+
jcristau
: approval-mozilla-beta+
Details 
Regression of bug 1404688.
status-firefox59: --- → unaffected
status-firefox60: --- → affected
status-firefox61: --- → affected
Priority: -- → P1
Assignee: nobody → ntim.bugs
Comment on attachment 8966792 [details]
Bug 1452019 - Fix tab_selected when lwt-image attribute is not set.

https://reviewboard.mozilla.org/r/235470/#review241222
Attachment #8966792 - Flags: review?(jaws) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/43742a3a7677
Fix tab_selected when lwt-image attribute is not set. r=jaws
https://hg.mozilla.org/mozilla-central/rev/43742a3a7677
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox61: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment on attachment 8966792 [details]
Bug 1452019 - Fix tab_selected when lwt-image attribute is not set.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1404688
[User impact if declined]: New theming api feature introduced in bug 1434476 is broken
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: n/a
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: no
[Why is the change risky/not risky?]: CSS only, has automated test
[String changes made/needed]:
Attachment #8966792 - Flags: approval-mozilla-beta?
Comment on attachment 8966792 [details]
Bug 1452019 - Fix tab_selected when lwt-image attribute is not set.

theming regression fix, approved for 60.0b13
Attachment #8966792 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Product: Toolkit → WebExtensions
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.