Closed
Bug 1452047
Opened 7 years ago
Closed 7 years ago
Youtube video chat box cannot be hidden
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1136312
People
(Reporter: ke5trel, Unassigned)
References
Details
(Keywords: site-compat)
Attachments
(1 file)
157 bytes,
text/html
|
Details |
STR:
1. Go to a Youtube video with enabled live/replay chat.
eg https://www.youtube.com/watch?v=tCf2mNyTsgQ
2. Click on the "HIDE CHAT" button.
Expected:
Chat box height should collapse to 0px and effectively hide it.
Actual:
Chat box #chatframe iframe reduces to 150px leaving chat still visible.
Comment 1•7 years ago
|
||
Seem to be related to flexbox. When flex is non-zero, the iframe would have height 150px regardless of its height property or attribute.
Comment 3•7 years ago
|
||
Let's set the attached testcase aside for a second. At the original YouTube URL, the iframe is intended to be hidden by this rule (when the "collapsed" attribute is applied to its parent):
> ytd-live-chat-frame[collapsed] iframe.ytd-live-chat-frame {
> height: 0;
If I additionally add "min-height:0" to that style rule, then the chat area does actually get hidden. This *shouldn't* be necessary for the web developer to do, but it currently is necessary in Firefox, due to our implementation being a bit out of date on one spec section. This is a version of bug 1331692 (for 'height' rather than 'width'), which is a piece of a more general flexbox spec update tracked in bug 1136312.
Now -- the attached testcase still renders differently between Chrome and Firefox, even if I add "min-height:0", so I think that's demonstrating an unrelated interop issue. I'll poke at that a bit more and possibly file a separate bug.
Flags: needinfo?(dholbert)
See Also: → 1331692
Comment 4•7 years ago
|
||
The testcase behaves differently because there are no other flex items vying for space, I think.
The reason the iframe has nonzero size in the attached testcase is that it has "flex: 1" which to us implies "flex:1 1 0%" in the spec snapshot that we implement, and 0% in an unconstrained-height container gets treated as an auto-height. Really, flex:1 should imply "flex: 1 0 0px" though, which is bug 1368592.
(Chrome also has flex:1 1 0% here; I'm not sure why they don't treat 0% as auto-height.)
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•