Closed Bug 1452060 Opened 2 years ago Closed 2 years ago

CamelCase all React component files in /devtools/client/framework/components

Categories

(DevTools :: Framework, enhancement, P3)

enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: jdescottes, Assigned: migueluseche)

References

Details

(Keywords: good-first-bug)

Attachments

(1 file)

We recently agreed to name our React component file names using the CamelCase convention.

However the files in /devtools/client/framework/components do not follow this convention, so let's rename them.

This is an easy fix, but make sure you read the contribution docs before starting: http://docs.firefox-dev.tools/ so that you can build Firefox locally and verify that things still work after your change.
After building, just running the built Firefox and opening the memory panel (by first enabling it from the settings panel) should be enough of a test that things still work.
Sorry for copy pasting a summary, I assumed the last part was just a set of generic instructions:

"After building, just running the built Firefox and opening the memory panel (by first enabling it from the settings panel) should be enough of a test that things still work."

Should be 

"After building, just running the built Firefox and opening the DevTools, checking tabs are still displayed etc... should be enough of a test that things still work"

Note that Bug 1442531 is currently modifying those components, so I will block this bug on it.
Depends on: 1442531
Can I take this? seems like nobody else is interested.
Sure, assigned to you :) Thanks!
Assignee: nobody → migueluseche
Status: NEW → ASSIGNED
Here's the patch for the bug.
Flags: needinfo?(jdescottes)
Comment on attachment 8973548 [details] [diff] [review]
CamelCase all React Components inside /devtools/client/framework/components

Review of attachment 8973548 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for fixing this Miguel!
Pushed to try, just in case: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7520edda76835c9cbefe4b8d1c7a6206d0f986a2
Attachment #8973548 - Flags: review+
Green try, adding checkin-needed, thanks again!
Keywords: checkin-needed
Flags: needinfo?(jdescottes)
Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/652be077994d
CamelCase all React component inside client framework folder. r=jdescottes
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/652be077994d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Target Milestone: Firefox 61 → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.