1452064 - CamelCase all React component files in /devtools/client/dom/content/components/

Status: RESOLVED FIXED

(DevTools :: DOM, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

We recently agreed to name our React component file names using the CamelCase convention.

However the files in /devtools/client/dom/content/components do not follow this convention, so let's rename them.

This is an easy fix, but make sure you read the contribution docs before starting: http://docs.firefox-dev.tools/ so that you can build Firefox locally and verify that things still work after your change.
After building, just running the built Firefox and opening the memory panel (by first enabling it from the settings panel) should be enough of a test that things still work.

Comment 1

[Julian Descottes [:jdescottes]]

Sorry for copy pasting a summary, I assumed the last part was just a set of generic instructions:

"After building, just running the built Firefox and opening the memory panel (by first enabling it from the settings panel) should be enough of a test that things still work."

Should be 

"After building, just running the built Firefox and opening the DOM panel (by first enabling it from the settings panel) should be enough of a test that things still work"

Comment 2

[migueluseche]

May I take this?

Comment 3

[Julian Descottes [:jdescottes]]

Sure, thanks for jumping on this :) Assigned to you!

Comment 4

[migueluseche]

Attachment: bug-1452064.patch

Here's the patch. I tested by doing memory snaps and it worked.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@migueluseche: The patch looks good, but the commit message is somehow wrong and there is no reviewer associated (not recognized by Bugzilla). It might be perhaps the slashes in the message...

You might try:
Bug 1452064 - CamelCase all React component files for DOM panel. r=pbro

Also, :pbro is on PTO, so you can ask me for review if you want to get it faster.

In such case:
Bug 1452064 - CamelCase all React component files for DOM panel. r=Honza

Honza

Comment 6

[migueluseche]

Attachment: Updated patch with new commit message

Here's the updated patch with suggested commit message.

Comment 7

[migueluseche]

Sorry, I forgot to mark previous patch as obsolete now I can't find how to do it.

Comment 8

[Julian Descottes [:jdescottes]]

(In reply to migueluseche from comment #7)
> Sorry, I forgot to mark previous patch as obsolete now I can't find how to
> do it.

Steps:
- go to the details page for the attachment to mark as obsolete
  here: https://bugzilla.mozilla.org/attachment.cgi?id=8967989&action=edit
- click on "Edit details" (next to "[patch] bug-1452064.patch")
- check "obsolete" checkbox
- submit

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8968522 [details] [diff] [review]
Updated patch with new commit message

Review of attachment 8968522 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks for helping with this!
R+
Honza

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@migueluseche: two things you should do now

1) Mark the previous patch as obsolete (see instructions in comment #8)

2) Add `checkin-needed` keyword into the Keywords field. It will ensure that somebody will land your patch into mozilla-central (m-c) repo. In order to do this, click the blue 'Edit Bug' button at the top of this page and search for Keywords field in section Tracking.

Thanks,
Honza

Comment 11

[migueluseche]

Done, thanks for your patience.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/19faa628ee03
CamelCase all React component files for DOM panel. r=Honza

Comment 13

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/19faa628ee03