Closed
Bug 1452101
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 9962 - Revert "bluetooth: Use DeviceUUID in FakeBluetooth"
Categories
(Core :: DOM: Device Interfaces, enhancement, P4)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 9962 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/9962 Details from upstream follow. Trent Apted <tapted@chromium.org> wrote: > Revert "bluetooth: Use DeviceUUID in FakeBluetooth" > > This reverts commit af1c15b16f99d290799c83d34c111bce52447026. > > Reason for revert: suspected for persistent failures on Win7 Tests (dbg)(1) > > Unexpected Failures: > * external/wpt/bluetooth/server/getPrimaryServices/blocklisted-services.https.html > * external/wpt/bluetooth/service/getCharacteristic/gen-blocklisted-characteristic.https.html > * external/wpt/bluetooth/service/getCharacteristics/blocklisted-characteristics.https.html > * external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html > * external/wpt/upgrade-insecure-requests/link-upgrade.sub.https.html > > since > > https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/66761 > > errors like > > 15:59:42.310 5904 worker/4 external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html crashed, (stderr lines): > 15:59:42.311 5904 CONSOLE MESSAGE: line 255: Web Bluetooth is experimental on this platform. See https://github.com/WebBluetoothCG/web-bluetooth/blob/gh-pages/implementation-status.md > 15:59:42.327 1300 [1691/5755] external/wpt/bluetooth/service/getCharacteristics/gen-blocklisted-characteristic-with-uuid.https.html failed unexpectedly (content_shell crashed [pid=5644]) > > > Original change's description: > > bluetooth: Use DeviceUUID in FakeBluetooth > > > > This change refactors the Web Bluetooth test API to use the > > DeviceUUIDs helper class defined in BluetoothDevice. Additionally, > > this change finishes the implementation of SimulateGATTServicesChanged, > > and as a result, tests are updated to set the next discovery response > > before calling this interface. > > > > BUG=719826 > > > > Change-Id: I0f986eb7afe6fbf7ebaa80ac4b633d46a027b80d > > Reviewed-on: https://chromium-review.googlesource.com/939984 > > Commit-Queue: Ovidio Henriquez <odejesush@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#541577} > > TBR=cco3@chromium.org,ortuno@chromium.org,odejesush@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 719826 > Change-Id: I02bb7066c6f1282191f7a24e91b3d2c5614b8104 > Reviewed-on: https://chromium-review.googlesource.com/958741 > Reviewed-by: Trent Apted <tapted@chromium.org> > Commit-Queue: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542421} > > >
Reporter | ||
Updated•6 years ago
|
Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=af76c7670ddf800918fddbb4e6a95b932fcf208c
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f3a5c39f769c953cf3fced4f431e4ec6bbc6431c
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/15ae72c25b3c [wpt PR 9962] - Revert "bluetooth: Use DeviceUUID in FakeBluetooth", a=testonly
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•