1452113 - Cleanup non-stylo wpt expectations.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: 0001-Bug-1452113-cleanup-non-stylo-wpt-expectations.-r-jg.patch

Mozreview is not happy at this for whatever reason.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Stop generating stylo-dependent expectations.

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8965755 [details] [diff] [review]
Stop generating stylo-dependent expectations.

Review of attachment 8965755 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/65b1af9b13d7
cleanup non-stylo wpt expectations. r=jgraham
https://hg.mozilla.org/integration/mozilla-inbound/rev/1eed58a0464e
Stop generating stylo expectations. r=jgraham

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ad5d38bd2b66
followup: Fixup some test expectations in a CLOSED TREE. r=me

Comment 6

[Cristian Brindusan [:cbrindusan]]

Backed out for web platform reftests in svg/path/bearing/relative.svg

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c72fee82cffcfb9fa5b50e4794be36de700ee3f

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=ad5d38bd2b669eae7898e61185dcdbcd9b8814ca&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=success&filter-resultStatus=superseded&filter-resultStatus=pending&filter-resultStatus=running

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=172429371&repo=mozilla-inbound&lineNumber=11288

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Are there any stylo regressions in here that ought to be looked into?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Mostly not, https://github.com/servo/servo/pull/20583 was the most concerning one. There are others about duplicate descriptors being treated differently in @feature-values, but I think that's a test bug, keeping two duplicate descriptors would be inconsistent with how style declarations work.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48ce0205de37
cleanup non-stylo wpt expectations. r=jgraham
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea3453cc7d92
Stop generating stylo expectations. r=jgraham

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/48ce0205de37
https://hg.mozilla.org/mozilla-central/rev/ea3453cc7d92

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2a0df546590
Stop generating stylo expectations: Add back annotation for detached-buffers.sharedworker.html to fix Linux 32-bit failures. r=wpt-fix

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e2a0df546590

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10427 for changes under testing/web-platform/tests

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged