Closed
Bug 1452119
Opened 6 years ago
Closed 6 years ago
Stop removing the resolutionchange event listener in TabsInTitlebar.uninit
Categories
(Firefox :: Theme, enhancement, P3)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: dao, Assigned: manishkk, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file)
|
791 bytes,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
As per bug 1448613 comment 9 ff., we can remove this line: https://searchfox.org/mozilla-central/rev/d0413b711da4dac72b237d0895daba2537f1514c/browser/base/content/browser-tabsintitlebar.js#301
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → 1991manish.kumar
|
||
Comment 2•6 years ago
|
||
Why do you remove the line instead of adding one for the "resize" event to match the registration?
|
Reporter | |
Comment 3•6 years ago
|
||
(In reply to Jorg K (GMT+1) from comment #2) > Why do you remove the line instead of adding one for the "resize" event to > match the registration? Because it's unnecessary.
|
|
Reporter | |
Updated•6 years ago
|
Attachment #8965837 -
Flags: review?(dao+bmo) → review+
|
|
Reporter | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by csabou@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3156b6ae002b Stop removing the resolutionchange event listener in TabsInTitlebar.uninit r=dao
Keywords: checkin-needed
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3156b6ae002b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in
before you can comment on or make changes to this bug.
Description
•