Closed Bug 1452136 Opened 6 years ago Closed 6 years ago

Audit *Unsafe MacroAssembler methods

Categories

(Core :: JavaScript Engine: JIT, enhancement, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox60 --- wontfix
firefox61 - fix-optional

People

(Reporter: jandem, Assigned: nbp)

References

(Blocks 1 open bug)

Details

We mitigated most object type checks, but there are a few callers of loadObjGroupUnsafe (and some other *Unsafe methods) that we have to audit still.
status-firefox61: --- → affected
Priority: -- → P1
When do you plan to work on this issue?
Flags: needinfo?(jdemooij)
tracking-firefox61: --- → ?
I was asked to file it but I'm not working on this.
Flags: needinfo?(jdemooij)
Needs an assignee or a reduction in priority.
status-firefox60: fix-optional → wontfix
tracking-firefox61: ? → +
Flags: needinfo?(nicolas.b.pierron)
Flags: needinfo?(jorendorff)
Reduced priority. Jan, I think this is appropriate. If not, please find someone to take the bug, or set tracking? for the next release.
status-firefox61: affected → fix-optional
Flags: needinfo?(nicolas.b.pierron)
Flags: needinfo?(jorendorff)
Flags: needinfo?(jdemooij)
Priority: P1 → P2
Flags: needinfo?(jdemooij) → needinfo?(sdetar)
I will look at this bug soon.
Flags: needinfo?(sdetar) → needinfo?(nicolas.b.pierron)
Priority: P2 → P1
To be precise *Unsafe in this bug title corresponds to callers of:
 - branchTestObjShapeUnsafe
 - branchTestObjGroupUnsafe
 - loadObjGroupUnsafe
 - loadObjClassUnsafe

I will start auditing these call sites.
Assignee: nobody → nicolas.b.pierron
Status: NEW → ASSIGNED
Flags: needinfo?(nicolas.b.pierron)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.