Closed Bug 1452159 Opened 2 years ago Closed 2 years ago

periodic file updates need to clear out old phabricator requests

Categories

(Release Engineering :: General, enhancement)

enhancement
Not set

Tracking

(firefox-esr60 fixed, firefox61 fixed)

RESOLVED FIXED
Tracking Status
firefox-esr60 --- fixed
firefox61 --- fixed

People

(Reporter: sfraser, Assigned: sfraser)

References

Details

Attachments

(2 files)

Currently each new run of the periodic file updates generates a new request in phabricator. Since it's a pain to follow up on those if they're left for a few days, let alone a week or more, the script should clear up after itself and mark the older requests as obsolete if they're still outstanding.
Assignee: nobody → sfraser
the periodic file updates keep adding new reviews, and it's easy to fall behind.
This adjusts the script so it clears out any previous submissions that are still awaiting review.
Comment on attachment 8965768 [details]
Bug 1452159 periodic file update clears out old reviews r=jlorenzo

Johan Lorenzo [:jlorenzo] has approved the revision.

https://phabricator.services.mozilla.com/D872
Attachment #8965768 - Flags: review+
Nice to not get too many reviews stuck in review. Thank you for this clean up!
Pushed by sfraser@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8924788c2d5b
periodic file update clears out old reviews r=jlorenzo
Depends on: 1452584
https://hg.mozilla.org/mozilla-central/rev/8924788c2d5b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
a difference in behaviours between awks meant the original didn't work in-situ,
although the task didn't fail due to the pipe chain.
Comment on attachment 8966536 [details]
Bug 1452159 periodic file udpates, fix awk behaviour r=jlorenzo

Johan Lorenzo [:jlorenzo] has approved the revision.

https://phabricator.services.mozilla.com/D899
Attachment #8966536 - Flags: review+
Pushed by sfraser@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/efe7d9c93434
periodic file udpates, fix awk behaviour r=jlorenzo
https://hg.mozilla.org/mozilla-central/rev/efe7d9c93434
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.