Closed Bug 1452181 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 10019 - [LayoutNG] Don't resolve unresolvable percentage min-height and max-height.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10019 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10019
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:
>  [LayoutNG] Don't resolve unresolvable percentage min-height and max-height.
>  
>  We cannot use the content size (intrinsic block size) as min-height or
>  max-height (min-width or max-width, if writing mode is vertical).
>  Doing so would cause min-height to incorrectly override any specified
>  height or max-height that is less than the intrinsic block size, and
>  max-height to override any specified height that's greater than the
>  intrinsic block size. Do what the spec says [1] instead: max-height
>  to become 'none', and min-height to become 0.
>  
>  This fixes the final rendering problem with Acid2 (this was about the
>  min-height issue). It now renders correctly with LayoutNG!
>  
>  Since no other tests than Acid2 started to pass with this change, I wrote
>  a couple.
>  
>  [1] https://www.w3.org/TR/CSS22/visudet.html#min-max-heights
>  
>       XXXXXX
>     XX      XX
>    X          X
>   X   O    O   X
>   X            X
>  X      /\      X
>  X      \/      X
>  X              X
>   X X        X X
>   X  XXXXXXXX  X
>    X          X
>     XX      XX
>       XXXXXX
>  
>  Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
>  Change-Id: Ic4f2c3c1dbc2bd66956ed4b270b08058999bc351
>  Reviewed-on: https://chromium-review.googlesource.com/960085
>  Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
>  Reviewed-by: Aleks Totic <atotic@chromium.org>
>  Reviewed-by: Emil A Eklund <eae@chromium.org>
>  Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#543018}
>  
>  
>
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 2 tests and 2 subtests
OK     : 2
PASS   : 2
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aacd2f782b2b
[wpt PR 10019] - [LayoutNG] Don't resolve unresolvable percentage min-height and max-height., a=testonly
https://hg.mozilla.org/mozilla-central/rev/aacd2f782b2b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.