Closed Bug 1452182 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 9921 - [css-grid] Minimum width items should include margins for indefinite grid containers

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 9921 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9921
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:
>  [css-grid] Minimum width items should include margins for indefinite grid containers
>  
>  We had a TODO in IndefiniteSizeStrategy::MinLogicalWidthForChild()
>  that was always using 0 as margin of the item.
>  The patch just changes that for a call
>  to GridLayoutUtils::MarginLogicalWidthForChild()
>  (like we do in the DefiniteSizeStrategy version).
>  
>  BUG=816762
>  TEST=external/wpt/css/css-grid/grid-items/grid-items-minimum-width-001.html
>  TEST=external/wpt/css/css-grid/grid-items/grid-items-minimum-width-002.html
>  
>  Change-Id: I743584aff234625f2d00327c711c0577ffeab457
>  Reviewed-on: https://chromium-review.googlesource.com/955062
>  Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
>  Reviewed-by: Javier Fernandez <jfernandez@igalia.com>
>  Cr-Commit-Position: refs/heads/master@{#543046}
>  
>  
>
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd77044e9e57
[wpt PR 9921] - [css-grid] Minimum width items should include margins for indefinite grid containers, a=testonly
https://hg.mozilla.org/mozilla-central/rev/cd77044e9e57
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Try push failed: decision task returned error
Try push failed: decision task returned error
You need to log in before you can comment on or make changes to this bug.