Closed Bug 1452186 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 9996 - [LayoutNG] Use the containing LayoutBlock for legacy write-back.

Categories

(Testing :: web-platform-tests, enhancement, P4)

enhancement

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 9996 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/9996
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:
>  [LayoutNG] Use the containing LayoutBlock for legacy write-back.
>  
>  The LayoutBox associated with a block node will *normally* be the
>  containing block (on the legacy side) of its children (on the NG side),
>  but this isn't an invariant. Multicol and list item markers are
>  two examples.
>  
>  Remove the kembo DCHECK, since it seems impossible to come up with a
>  complete list of exceptions to the rule (that the node's box should be
>  the containing block of the child nodes' boxes). Instead always get the
>  right containing block from legacy layout. Don't use that of the node.
>  
>  With the DCHECK removed, a lot of tests stop crashing, and some just
>  start passing instead. One known effect of this change is that floats
>  that are direct children of multicol containers are painted correctly.
>  They used to be added to the float list of the multicol container,
>  rather than that of the flow thread, which caused two problems: paint
>  order (regular blocks got painted on top of them), and that they
>  appeared unfragmented (they just overflowed the multicol container
>  instead). Added a test for that.
>  
>  Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
>  Change-Id: I1ee926c39fbedfd52d87e9cf790996909914efb2
>  Reviewed-on: https://chromium-review.googlesource.com/960027
>  Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
>  Reviewed-by: Emil A Eklund <eae@chromium.org>
>  Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
>  Reviewed-by: Aleks Totic <atotic@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#543065}
>  
>  
>
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a1e03b0b63d
[wpt PR 9996] - [LayoutNG] Use the containing LayoutBlock for legacy write-back., a=testonly
https://hg.mozilla.org/mozilla-central/rev/6a1e03b0b63d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
Try push failed: decision task returned error
You need to log in before you can comment on or make changes to this bug.