1452201 - Use a shared messengercompose.css where possible

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

Like we do already for other CSS files, we should use a shared file for messengercompose.css.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: shared-messengercompose.patch

This should be relative easy to check, as every removed line in the existing files should be in the shared file.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8965807 [details] [diff] [review]
shared-messengercompose.patch

I didn't compare the hunks, but it still seems to be working :-)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f24dba448f48
Use a shared messengercompose.css where possible. r=jorgk

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 8965807 [details] [diff] [review]
shared-messengercompose.patch

Can we uplift this? Then later uplifts in this area would need no or lesser changes.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8965807 [details] [diff] [review]
shared-messengercompose.patch

OK, although the reshuffling is a little risky.

Comment 6

[Jorg K (CEST = GMT+2)]

Beta (TB 60 beta 3):
https://hg.mozilla.org/releases/comm-beta/rev/63d73d4ad8fb8f2e5ffde1c315caada905ec61df

There were three merge failures on the removal of
-#TextColorButton {
-#TextColorButton[color="mixed"] {
-#BackgroundColorButton {
due to the overlay removal bugs.

Removed them manually from Mac, Windows and Linux.