1452209 - DOM tree search is unreliable and confusing

Status: RESOLVED WORKSFORME

(DevTools :: Inspector, defect, P2)

Description

[Markus Stange [:mstange]]

STR:
 1. Open the Browser Toolbox for a Firefox browser window.
 2. Enter "remote" into the searchbar, press exit to close the autocomplete that pops up, and press enter to start the search.
 3. Keep pressing enter to go through the search results.

At some point, things will break: No element will be selected, and the DOM view will be scrolled to a random position. For me, the bad behavior starts at result 36 of 57.

Comment 1

[Julien Wajsberg [:julienw]]

I reproduce, the behavior is very strange from the first results for me.

As a data point, this seems to work fine in the Inspector for normal Web Page, I tried searching for "style" in this bugzilla page and it worked properly.

Comment 2

[Patrick Brosset <:pbro>]

Thanks for filing Markus. I suspect the treewalker we use to search isn't the same one we use to display the DOM in the panel. So at some point, results come in that the inspector just doesn't know how to display.
This will require more investigation though, just a guess for now.

Comment 3

[Patrick Brosset <:pbro>]

For more details, I think the problem is in the walker-search.js module, around these lines:
https://searchfox.org/mozilla-central/rev/d0a41d2e7770fc00df7844d5f840067cc35ba26f/devtools/server/actors/utils/walker-search.js#83-117

In order to find nodes, this uses `this.walker.getDocumentWalker`, so the document walker that we use to display nodes in the DOM too, but we probably just don't give it the right options for it to filter in or out the right nodes.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

The provided STR does seem to work well for me, maybe things improved with all the work that was done for Fission?

Comment 5

[Markus Stange [:mstange]]

The STR work well for me now, too.