1452215 - Assert fail in GetSubscriptionCallback::OnPushSubscription

Status: RESOLVED DUPLICATE of bug 1633469

(Core :: DOM: Core & HTML, defect, P3)

Description

[mozillabugs]

I had 5 sites loaded [1] and was playing a cat video on Youtube [2] when I got this crash in the cat video content process:

>	xul.dll!mozilla::dom::`anonymous namespace'::GetSubscriptionCallback::OnPushSubscription(nsresult aStatus, nsIPushSubscription * aSubscription) Line 244	C++
 	xul.dll!mozilla::dom::`anonymous namespace'::GetSubscriptionCallback::OnPushSubscriptionError(nsresult aStatus) Line 253	C++
 	xul.dll!mozilla::dom::`anonymous namespace'::GetSubscriptionRunnable::Run() Line 315	C++
 	xul.dll!nsThread::ProcessNextEvent(bool aMayWait, bool * aResult) Line 1038	C++
 	xul.dll!NS_ProcessNextEvent(nsIThread * aThread, bool aMayWait) Line 513	C++
 	xul.dll!mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate * aDelegate) Line 97	C++
 	xul.dll!mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate * aDelegate) Line 302	C++
 	xul.dll!MessageLoop::RunInternal() Line 327	C++
 	xul.dll!MessageLoop::RunHandler() Line 320	C++
 	xul.dll!MessageLoop::Run() Line 300	C++
 	xul.dll!nsBaseAppShell::Run() Line 161	C++
 	xul.dll!nsAppShell::Run() Line 230	C++
 	xul.dll!XRE_RunAppShell() Line 877	C++
 	xul.dll!mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate * aDelegate) Line 269	C++
 	xul.dll!MessageLoop::RunInternal() Line 327	C++
 	xul.dll!MessageLoop::RunHandler() Line 320	C++
 	xul.dll!MessageLoop::Run() Line 300	C++
 	xul.dll!XRE_InitChildProcess(int aArgc, char * * aArgv, const XREChildData * aChildData) Line 707	C++
 	xul.dll!mozilla::BootstrapImpl::XRE_InitChildProcess(int argc, char * * argv, const XREChildData * aChildData) Line 70	C++
 	firefox.exe!content_process_main(mozilla::Bootstrap * bootstrap, int argc, char * * argv) Line 63	C++
 	firefox.exe!NS_internal_main(int argc, char * * argv, char * * envp) Line 280	C++
 	firefox.exe!wmain(int argc, wchar_t * * argv) Line 111	C++
 	[External Code]	

I have a dump that I will answer questions about, but not upload.

[1] guardian.co.uk ; nytimes.com ; seattletimes.com ; latimes.com ; youtube.com

[2] Isn't that what the internet is really for?

Comment 1

[mozillabugs]

The video was entitled "NO WAY you can WATCH & NOT LAUGH! - Super FUNNY CATS" (capitalization in original). FF crashes about 30 seconds in.

Comment 2

[mozillabugs]

I tried to reproduce the bug twice, but it didn't crash again.

Comment 3

[u408661]

Code lives in DOM

Comment 4

[mozillabugs]

I got the same assert on FF 59.0.2 Win64 debug a moment ago while loading the Youtube video "Man Wakes Up to Find Something Scaringly Beautiful On His Front Porch. You Won't Believe What It Is".

Comment 5

[mozillabugs]

On FF 59.0.2 Win64 debug, this assert seems to happen everytime I attempt to play a Youtube video.

Comment 6

[Andrew McCreight [:mccr8]]

Are you still seeing this? What is the assert?

Comment 7

[mozillabugs]

(In reply to Andrew McCreight [:mccr8] from comment #6)
> Are you still seeing this? What is the assert?

Yes. I see the comment 0 assert every time I try to load a Youtube video in the DEBUG Win64 build of 59.0.2, but it happens only with a certain profile, not with a new profile.

I will try to determine what difference between the crashing profile and the new profile causes the assert.

Comment 8

[mozillabugs]

I haven't seen this in the latest few FF versions.

Comment 9

[Lina Butler [:lina]]

Thanks for the report! I suspect that was happening because MOZ_ALWAYS_TRUE did a MOZ_ASSERT internally, which only asserts and crashes on debug builds. Now that we've switched it to MOZ_DIAGNOSTIC_ASSERT (bug 1620152) under the hood, the same thing is happening in non-debug builds. I think it's the same underlying cause as bug 1633469, so let's dupe this forward.