Closed Bug 1452235 Opened Last year Closed Last year

Remove nsIDOMSerializer

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

No description provided.
Jorg, I will be removing the "@mozilla.org/xmlextras/xmlserializer;1" and replacing it with ChromeUtils.importGlobalProperties(["XMLSerializer"]); followed by |new XMLSerializer()|.  There look like one use each in calendar and mailnews that will need updating.
MozReview-Commit-ID: IB4W7R7Rg2P
Attachment #8965891 - Flags: review?(kyle)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
MozReview-Commit-ID: BuIhA13GuLj
Attachment #8965892 - Flags: review?(kyle)
MozReview-Commit-ID: JbWGcfbmM4b
Attachment #8965893 - Flags: review?(kyle)
MozReview-Commit-ID: 5foaztSLyEC
Attachment #8965894 - Flags: review?(kyle)
Depends on: 1452352
(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #1)
> replacing it with ChromeUtils.importGlobalProperties(["XMLSerializer"]);
> followed by |new XMLSerializer()|.
That can land already, right?
> That can land already, right?

Not until part 3 of this bug lands; before then importGlobalProperties doesn't know about XMLSerializer.
Attachment #8965891 - Flags: review?(kyle) → review+
Comment on attachment 8965892 [details] [diff] [review]
part 2.  Remove nsIDOMSerializer::SerializeToString

Review of attachment 8965892 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/XMLSerializer.webidl
@@ +12,5 @@
>  interface XMLSerializer {
> +  /**
> +   * The subtree rooted by the specified element is serialized to
> +   * a string.
> +   * 

nit: extra whitespace
Attachment #8965892 - Flags: review?(kyle) → review+
Attachment #8965893 - Flags: review?(kyle) → review+
Attachment #8965894 - Flags: review?(kyle) → review+
Attachment #8965895 - Flags: review?(kyle) → review+
> nit: extra whitespace

Fixed.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7391f0f3b60
part 1.  Remove nsIDOMSerializer::SerializeToStream.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/a53d6207c403
part 2.  Remove nsIDOMSerializer::SerializeToString.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/04c975671b12
part 3.  Stop using nsIDOMSerializer from JS.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/224c47afe070
part 4.  Remove nsIDOMSerializer.  r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c4d25c79093
part 5.  Stop inheriting nsISupports for nsDOMSerializer.  r=qdot
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.