Closed
Bug 1452235
Opened 6 years ago
Closed 6 years ago
Remove nsIDOMSerializer
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
8.22 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
6.88 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
7.33 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
11.76 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
5.44 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
Jorg, I will be removing the "@mozilla.org/xmlextras/xmlserializer;1" and replacing it with ChromeUtils.importGlobalProperties(["XMLSerializer"]); followed by |new XMLSerializer()|. There look like one use each in calendar and mailnews that will need updating.
Assignee | ||
Comment 2•6 years ago
|
||
MozReview-Commit-ID: IB4W7R7Rg2P
Attachment #8965891 -
Flags: review?(kyle)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•6 years ago
|
||
MozReview-Commit-ID: BuIhA13GuLj
Attachment #8965892 -
Flags: review?(kyle)
Assignee | ||
Comment 4•6 years ago
|
||
MozReview-Commit-ID: JbWGcfbmM4b
Attachment #8965893 -
Flags: review?(kyle)
Assignee | ||
Comment 5•6 years ago
|
||
MozReview-Commit-ID: 5foaztSLyEC
Attachment #8965894 -
Flags: review?(kyle)
Assignee | ||
Comment 6•6 years ago
|
||
MozReview-Commit-ID: 89iyRqKcAl0
Attachment #8965895 -
Flags: review?(kyle)
Comment 7•6 years ago
|
||
(In reply to Boris Zbarsky [:bz] (no decent commit message means r-) from comment #1) > replacing it with ChromeUtils.importGlobalProperties(["XMLSerializer"]); > followed by |new XMLSerializer()|. That can land already, right?
Assignee | ||
Comment 8•6 years ago
|
||
> That can land already, right?
Not until part 3 of this bug lands; before then importGlobalProperties doesn't know about XMLSerializer.
Updated•6 years ago
|
Attachment #8965891 -
Flags: review?(kyle) → review+
Comment 9•6 years ago
|
||
Comment on attachment 8965892 [details] [diff] [review] part 2. Remove nsIDOMSerializer::SerializeToString Review of attachment 8965892 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/webidl/XMLSerializer.webidl @@ +12,5 @@ > interface XMLSerializer { > + /** > + * The subtree rooted by the specified element is serialized to > + * a string. > + * nit: extra whitespace
Attachment #8965892 -
Flags: review?(kyle) → review+
Updated•6 years ago
|
Attachment #8965893 -
Flags: review?(kyle) → review+
Updated•6 years ago
|
Attachment #8965894 -
Flags: review?(kyle) → review+
Updated•6 years ago
|
Attachment #8965895 -
Flags: review?(kyle) → review+
Assignee | ||
Comment 10•6 years ago
|
||
> nit: extra whitespace
Fixed.
Comment 11•6 years ago
|
||
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f7391f0f3b60 part 1. Remove nsIDOMSerializer::SerializeToStream. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/a53d6207c403 part 2. Remove nsIDOMSerializer::SerializeToString. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/04c975671b12 part 3. Stop using nsIDOMSerializer from JS. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/224c47afe070 part 4. Remove nsIDOMSerializer. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/7c4d25c79093 part 5. Stop inheriting nsISupports for nsDOMSerializer. r=qdot
Comment 12•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f7391f0f3b60 https://hg.mozilla.org/mozilla-central/rev/a53d6207c403 https://hg.mozilla.org/mozilla-central/rev/04c975671b12 https://hg.mozilla.org/mozilla-central/rev/224c47afe070 https://hg.mozilla.org/mozilla-central/rev/7c4d25c79093
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•