Improve feed error handling and logging

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dylan, Assigned: dkl)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

45 bytes, text/x-github-pull-request
Details | Review
The feed should handle bad data from phabricator (such as invalid bug ids)
and also many logging messages should be WARN or ERROR instead of DEBUG.
(Reporter)

Comment 1

a year ago
I'm going to let dkl handle this, as he has better idea of needs.


dkl: I think you need to do two things here -- when you get a bad transaction from phabricator, such as one about a bug
that doesn't exist, you need to either fail very loudly (enough that ckolos would be altered),
OR you need to skip the bad data.

Also the logging messages should be re-leveled, so that with log level INFO (the default)
the output is useful. It looks like me like several of the DEBUG-type statements are better suited as WARN
or even ERROR().

sort of like this:

TRACE -- used in development when want to follow execution flow in detail
DEBUG -- used only in development when you're trying to see what is going on
NOTICE/INFO -- the program did something useful ("I processed six jobs!")
WARN -- something odd happened ("This phabricator revision is weird"
ERROR -- an error happened, but you were able to handle it
FATAL -- an error happened, and you have no idea how the program can proceed.
Assignee: dylan → dkl
Blocks: 1453733
(Reporter)

Comment 2

a year ago
please attach the PR to this bug
Status: NEW → ASSIGNED
Flags: needinfo?(dkl)
(Assignee)

Comment 3

a year ago
Posted file github pr #535
Flags: needinfo?(dkl)
(Assignee)

Updated

a year ago
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.