145225 - Margins settings aren't remembered

Status: RESOLVED FIXED

(Core :: Printing: Output, defect, P2)

Description

[Aleksander Adamowski]

Build: 2002051521 trunk.
Reproducible: always

To reproduce:
1. Launch Mozilla
2. Enter File -> Page Setup -> Margins & Header/Footer
3. Change the top margin to 0.8 Inches and click OK
4. Test the setting by printing something, or entering Page Setup again: top
margin should still be at 0.8
5. Quite Mozilla and restart it
6. Enter Page Setup again.

Results: top margin is back at 0.5

Expected results: top margin should be at 0.8, as it was left before closing
Mozilla.

Comment 1

[rods (gone)]

We are purposely not doing this at th moment. If it is something a lot of folks
want I will attach the patch.

Comment 2

[rods (gone)]

Attachment: patch

Patch for having margins saved

Comment 3

[Aleksander Adamowski]

What's the purpose of not doing it?

Comment 4

[rods (gone)]

Well, it seems reasonsable and IE remembers the amrgin settings from one
execution to another.

The patch is no risk nominating for nsbeta1, this effects any platforms using
the XP PageSetup (Mac9, Win, Linux, OS2)

Comment 5

[rods (gone)]

Comment on attachment 84051 [details] [diff] [review]
patch

this doesn't work

Comment 6

[rods (gone)]

Will have to give this some thought. Need to be able to read/write a generic
margin setting, but also let them be global or unique to each window.

One solution is: If the app is using "global" PrintSettings, is to have it save
out just the margin settings when the PrintSettingsService shutdown.

Comment 7

[Marco Franzen]

The description of this bug sounds as if it must (also) invoke bug 150416 (0.8 >
0.5).

Comment 8

[sujay]

*** Bug 163866 has been marked as a duplicate of this bug. ***

Comment 9

[R.K.Aa.]

*** Bug 151214 has been marked as a duplicate of this bug. ***

Comment 10

[Adam Hauner]

Duplicated bug 163866 was for W2K, changing OS -> All. 

Comment 11

[rods (gone)]

I think this will soon be fixed by a different bug.

Comment 12

[rods (gone)]

fixed with check in to Bug 167894