Closed Bug 1452283 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 10304 - Out-of-flow descendants may still be part of the flow thread.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10304 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10304
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:
>  Out-of-flow descendants may still be part of the flow thread.
>  
>  When changing a layout object from in-flow to out-of-flow positioned, we
>  used to just remove it from the flow thread, risking that there'd no
>  longer be a column set to associate it with. However, an out-of-flow
>  positioned descendant may be contained by something that's inside the
>  flow thread, e.g. if the containing block of an absolutely positioned
>  object is a relatively positioned object, and that relatively positioned
>  object is contained by the flow thread.
>  
>  Since it's hard to detect what the new containing block of an object is
>  going to be before it has actually gone out of flow, we'll still remove
>  it from the flow thread, but we'll now detect that we need to re-insert
>  it when computed style has updated.
>  
>  Bug: 827424
>  Change-Id: I413348b0d3ecd0c4b5051e6e9d2a4526863bef60
>  Reviewed-on: https://chromium-review.googlesource.com/995439
>  Reviewed-by: Emil A Eklund <eae@chromium.org>
>  Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#548354}
>  
>  
>
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests and 1 subtests
OK     : 1
PASS   : 1
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6383fc38056
[wpt PR 10304] - Out-of-flow descendants may still be part of the flow thread., a=testonly
https://hg.mozilla.org/mozilla-central/rev/f6383fc38056
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.