Closed
Bug 1452307
Opened 6 years ago
Closed 6 years ago
Remove old-style API experiment support
Categories
(WebExtensions :: General, enhancement)
WebExtensions
General
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
Details
Attachments
(2 files)
Now that we have support for API experiments with WebExtension-style manifests, there's no need to keep support for old-style API experiments around.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8965886 [details] Bug 1452307: Remove support for old-style experiment API extensions. https://reviewboard.mozilla.org/r/234712/#review240722 I didn't search very hard for other orphaned code that might have been overlooked but that can always get removed later if we discover something. Thanks for doing this!
Attachment #8965886 -
Flags: review?(aswan) → review+
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8966058 [details] Bug 1452307: Remove some dead code. https://reviewboard.mozilla.org/r/234774/#review240728
Attachment #8966058 -
Flags: review?(aswan) → review+
Assignee | ||
Comment 6•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc2f1762365b6d43b1aeb2056ebe5384bb0522cf Bug 1452307: Remove support for old-style experiment API extensions. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/107214f8a65dac49aa506f5411bf81d9ae6376c2 Bug 1452307: Remove some dead code. r=aswan
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8966058 [details] Bug 1452307: Remove some dead code. https://reviewboard.mozilla.org/r/234774/#review241382 ::: toolkit/components/extensions/Schemas.jsm:3060 (Diff revision 1) > } > > for (let [url, schema] of data) { > this.schemaJSON.set(url, schema); > } > - this.flushSchemas(); > + if (this._rootScheam) { `this._rootScheam` looks like a typo. ::: toolkit/components/extensions/Schemas.jsm:3092 (Diff revision 1) > Services.ppmm.broadcastAsyncMessage("Schema:Add", [[url, schema]]); > } else if (this.schemaHook) { > this.schemaHook([[url, schema]]); > } > > - this.flushSchemas(); > + if (this._rootScheam) { Here too.
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bc2f1762365b https://hg.mozilla.org/mozilla-central/rev/107214f8a65d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee | ||
Comment 9•6 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/515bfde909c6b8345709b55d467ea9c18d145847 Bug 1452307: Follow-up: Fix typeo. r=aswan
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/515bfde909c6
Comment 11•6 years ago
|
||
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag. Thanks!
Flags: needinfo?(kmaglione+bmo)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(kmaglione+bmo) → qe-verify-
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•