Closed Bug 1452307 Opened 6 years ago Closed 6 years ago

Remove old-style API experiment support

Categories

(WebExtensions :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

Attachments

(2 files)

Now that we have support for API experiments with WebExtension-style manifests, there's no need to keep support for old-style API experiments around.
Blocks: 1449052
Comment on attachment 8965886 [details]
Bug 1452307: Remove support for old-style experiment API extensions.

https://reviewboard.mozilla.org/r/234712/#review240722

I didn't search very hard for other orphaned code that might have been overlooked but that can always get removed later if we discover something.
Thanks for doing this!
Attachment #8965886 - Flags: review?(aswan) → review+
Comment on attachment 8966058 [details]
Bug 1452307: Remove some dead code.

https://reviewboard.mozilla.org/r/234774/#review240728
Attachment #8966058 - Flags: review?(aswan) → review+
Comment on attachment 8966058 [details]
Bug 1452307: Remove some dead code.

https://reviewboard.mozilla.org/r/234774/#review241382

::: toolkit/components/extensions/Schemas.jsm:3060
(Diff revision 1)
>          }
>  
>          for (let [url, schema] of data) {
>            this.schemaJSON.set(url, schema);
>          }
> -        this.flushSchemas();
> +        if (this._rootScheam) {

`this._rootScheam` looks like a typo.

::: toolkit/components/extensions/Schemas.jsm:3092
(Diff revision 1)
>        Services.ppmm.broadcastAsyncMessage("Schema:Add", [[url, schema]]);
>      } else if (this.schemaHook) {
>        this.schemaHook([[url, schema]]);
>      }
>  
> -    this.flushSchemas();
> +    if (this._rootScheam) {

Here too.
https://hg.mozilla.org/mozilla-central/rev/bc2f1762365b
https://hg.mozilla.org/mozilla-central/rev/107214f8a65d
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(kmaglione+bmo) → qe-verify-
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.