Closed Bug 1452309 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 10300 - [css-typed-om] Add support for background properties.

Categories

(Core :: DOM: CSS Object Model, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10300 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10300
Details from upstream follow.

Darren Shen <shend@chromium.org> wrote:
>  [css-typed-om] Add support for background properties.
>  
>  We cannot support background-repeat and background-position yet because
>  they are both implemented as shorthands in Blink, but are not shorthands
>  in the spec.
>  
>  We'd need to refactor the existing code to allow shorthands to reify
>  as proper Typed OM objects. There are also some tricky bits to support
>  styleMap.set with shorthands given a proper Typed OM object.
>  
>  Bug: 820299
>  Change-Id: I064ce37a48bee3d73965b66b323e20abf5a9099f
>  Reviewed-on: https://chromium-review.googlesource.com/994593
>  Commit-Queue: Darren Shen <shend@chromium.org>
>  Reviewed-by: Rune Lillesveen <futhark@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#548705}
>  
>  
>
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Ran 7 tests and 7 subtests
OK     : 7
FAIL   : 7

New tests that have failures or other problems:
/css/css-typed-om/the-stylepropertymap/properties/background-attachment.html
    'background-attachment' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/background-blend-mode.html
    'background-blend-mode' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/background-clip.html
    'background-clip' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/background-origin.html
    'background-origin' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/background-position.html
    'background-position' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/background-repeat.html
    'background-repeat' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/background-size.html
    'background-size' property: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ebed65d1009
[wpt PR 10300] - [css-typed-om] Add support for background properties., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/167311c84a84
[wpt PR 10300] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/5ebed65d1009
https://hg.mozilla.org/mozilla-central/rev/167311c84a84
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.