Closed Bug 1452312 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 10299 - [css-typed-om] Add support for border properties.

Categories

(Core :: DOM: CSS Object Model, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10299 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10299
Details from upstream follow.

Darren Shen <shend@chromium.org> wrote:
>  [css-typed-om] Add support for border properties.
>  
>  border-radius-* tests are failing because the computed value should
>  always be a pair of values, but Blink currently returns a CSSValuePair
>  with kDropIdenticalValue, so we sometimes compute to a single value.
>  
>  Fixing this requires either changing computed border-radius-* to use
>  kKeepIdenticalValue, or overriding the computed value just for Typed OM
>  [1]
>  
>  [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp?q=ComputedStylePropertyMap.cpp&dr&l=229
>  
>  Bug: 820299
>  Change-Id: I4c67a7986a8e77d37e7936eabfa0b68b32de9df8
>  Reviewed-on: https://chromium-review.googlesource.com/994433
>  Commit-Queue: Darren Shen <shend@chromium.org>
>  Reviewed-by: Rune Lillesveen <futhark@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#548697}
>  
>  
>
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/17a3cc47b213
[wpt PR 10299] - [css-typed-om] Add support for border properties., a=testonly
https://hg.mozilla.org/mozilla-central/rev/17a3cc47b213
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.