Closed Bug 1452323 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 10349 - Cookie Store: Tentatively deflake special names test

Categories

(Testing :: web-platform-tests, defect, P4)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream error])

Sync web-platform-tests PR 10349 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10349
Details from upstream follow.

Joshua Bell <jsbell@chromium.org> wrote:
>  Cookie Store: Tentatively deflake special names test
>  
>  The "expires" cases are flaky on all platforms on the bots, although
>  I can't reproduce locally. The test case sets a cookie that expires
>  "now" then expects it can't read it. It may be flaky due to "now"
>  being slightly different between processes, threads, and libraries,
>  allowing the read to succeed.
>  
>  Set the expiry date to be an hour before "now", which should be
>  sufficient.
>  
>  Bug: 829761
>  Change-Id: Icda1891310dd0a56769877f32405226390e729de
>  Reviewed-on: https://chromium-review.googlesource.com/999743
>  Commit-Queue: Joshua Bell <jsbell@chromium.org>
>  Reviewed-by: Victor Costan <pwnall@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#548903}
>  
>  
>
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e70c75623c6
[wpt PR 10349] - Cookie Store: Tentatively deflake special names test, a=testonly
https://hg.mozilla.org/mozilla-central/rev/0e70c75623c6
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.