Closed Bug 1452416 Opened 6 years ago Closed 6 years ago

Crash in [@ mozilla::CycleCollectedJSContext::ProcessMetastableStateQueue ] fixed in FF55/56. Uplift Requested to ESR.

Categories

(Core :: Audio/Video: MediaStreamGraph, defect, P3)

52 Branch
defect

Tracking

()

RESOLVED FIXED
Tracking Status
relnote-firefox --- -
firefox-esr52 60+ fixed
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 --- unaffected

People

(Reporter: skywalker333, Assigned: jesup)

References

(Blocks 1 open bug)

Details

(Keywords: topcrash, Whiteboard: [stockwell fixed])

Crash Data

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1312623 +++

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=38132888&repo=mozilla-inbound

https://archive.mozilla.org/pub/mobile/tinderbox-builds/mozilla-inbound-android-api-15/1477329325/mozilla-inbound_ubuntu64_vm_armv7_large_test-mochitest-media-1-bm122-tests1-linux64-build386.txt.gz

(In reply to Wes Kocher (:KWierso) from comment #19)
> https://hg.mozilla.org/mozilla-central/rev/bc861f344831

Last Resolved: 9 months ago
status-firefox56: --- → fixed

(In reply to Julien Cristau [:jcristau] from comment #22)
> Comment on attachment 8883210 [details]
> Bug 1312623 - Don't attempt to shutdown a thread in the dtor of a
> GraphDriver, since it might be called by CC.
> 
> crash fix, beta55+

(In reply to Ryan VanderMeulen [:RyanVM] from comment #23)
> https://hg.mozilla.org/releases/mozilla-beta/rev/84b80aceba4c

status-firefox55: affected → fixed

----------

Request uplift to ESR 52 due to high crash volume/top crasher.

Top Crashers for Firefox 52.7.3esr

4 	1.7% 	-0.26% 	mozilla::CycleCollectedJSContext::ProcessMetastableStateQueue	1997 	1997 	0 	0 	1509 	1369 	2016-09-26



Signature report for mozilla::CycleCollectedJSContext::ProcessMetastableStateQueue
Showing results from 7 days ago

Windows 7 	998 	30.6%
Windows 10 	972 	29.8%
Windows Vista 	634 	19.4%
Windows XP 	594 	18.2%
Windows 8.1 	42 	1.3%
Windows Server 2003 	11 	0.3%
Linux 	4 	0.1%
Windows 8 	4 	0.1%
OS X 10.13 	2 	0.1%
Android 	1 	0.0%

Firefox 	52.7.3esr 	2409 	73.2% 	1960
Firefox 	52.6.0esr 	396 	12.0% 	257
Firefox 	52.7.2esr 	132 	4.0% 	110
Firefox 	52.3.0esr 	48 	1.5% 	17
Firefox 	52.7.0esr 	38 	1.2% 	39
Firefox 	52.5.0esr 	27 	0.8% 	17
Firefox 	52.4.0esr 	19 	0.6% 	12
Firefox 	52.5.3esr 	19 	0.6% 	19

x86 	3246 	99.5%
amd64 	15 	0.5%
arm 	1 	0.0%
No longer depends on: 1312623
See Also: → 1312623
Flags: needinfo?(ryanvm)
Paul, this crash has hit ESR52 over 4000 times in the last week, which is certainly high enough to justify uplift consideration. I checked and the fix [1] from bug 1330212 grafts cleanly. Any worries on your end about doing so? Randell suggested I check with you on it :)

[1] https://hg.mozilla.org/mozilla-central/rev/c90ec782d481
Flags: needinfo?(ryanvm) → needinfo?(padenot)
No worries, sounds good!
Flags: needinfo?(padenot)
[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: topcrash on ESR52
User impact if declined: 5000+ crashes in the last week
Fix Landed on Version: 53
Risk to taking this patch (and alternatives if risky): Very low per discussion in this bug. And it's very well-baked.
String or UUID changes made by this patch: None
Attachment #8966564 - Flags: review+
Attachment #8966564 - Flags: approval-mozilla-esr52?
Assignee: nobody → rjesup
Comment on attachment 8966564 [details] [diff] [review]
Release GraphDrivers outside of StableState runnable to avoid spinning the event queue

Approved for ESR 52.8.0.
Attachment #8966564 - Flags: approval-mozilla-esr52? → approval-mozilla-esr52+
We should add a release note for esr 52.8.
relnote-firefox: --- → ?
I'm adding a generic "stability fixes" note, but I don't see why we need to specifically call this crash fix out either.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: