Closed Bug 1452426 Opened 6 years ago Closed 5 years ago

Hook up invalidation testing for WebRender fallback and blob drawing

Categories

(Core :: Graphics: WebRender, enhancement, P2)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox61 --- disabled
firefox63 --- fixed

People

(Reporter: mstange, Assigned: jrmuizel)

References

Details

Attachments

(1 file)

Hook up invalidation testing in WebRender
2.40 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
FrameLayerBuilder calls frame->AddStateBits(NS_FRAME_PAINTED_THEBES) before it calls item->Paint():
https://searchfox.org/mozilla-central/rev/c5ba0f076697d8a6f4548f821b1d97c267ad207c/layout/painting/FrameLayerBuilder.cpp#6009-6012

This is what makes reftest-no-paint work.

We should do the same thing in the two places in WebRenderCommandBuilder where we call nsDisplayItem::Paint, in order to benefit from existing invalidation tests and so that we can add new tests if we encounter any invalidation bugs, for example with blob invalidation.
Assignee: nobody → jmuizelaar
This isn't directly user-facing, downgrading from P1.
Priority: P1 → P2
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3cf0bec611e1
Hook up invalidation testing in WebRender. r=mstange
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/77fa43334879
Hook up invalidation testing in WebRender. r=mstange
https://hg.mozilla.org/mozilla-central/rev/3cf0bec611e1
https://hg.mozilla.org/mozilla-central/rev/77fa43334879
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.