Hook up invalidation testing for WebRender fallback and blob drawing

RESOLVED FIXED in Firefox 63

Status

()

P2
normal
RESOLVED FIXED
10 months ago
5 months ago

People

(Reporter: mstange, Assigned: jrmuizel)

Tracking

(Blocks: 1 bug)

Trunk
mozilla63
Points:
---

Firefox Tracking Flags

(firefox61 disabled, firefox63 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 months ago
FrameLayerBuilder calls frame->AddStateBits(NS_FRAME_PAINTED_THEBES) before it calls item->Paint():
https://searchfox.org/mozilla-central/rev/c5ba0f076697d8a6f4548f821b1d97c267ad207c/layout/painting/FrameLayerBuilder.cpp#6009-6012

This is what makes reftest-no-paint work.

We should do the same thing in the two places in WebRenderCommandBuilder where we call nsDisplayItem::Paint, in order to benefit from existing invalidation tests and so that we can add new tests if we encounter any invalidation bugs, for example with blob invalidation.
Blocks: 1386665
Priority: -- → P1
status-firefox61: affected → disabled
(Assignee)

Updated

9 months ago
Assignee: nobody → jmuizelaar
This isn't directly user-facing, downgrading from P1.
Priority: P1 → P2
(Assignee)

Comment 2

5 months ago
Created attachment 9005283 [details] [diff] [review]
Hook up invalidation testing in WebRender
Attachment #9005283 - Flags: review+

Comment 3

5 months ago
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3cf0bec611e1
Hook up invalidation testing in WebRender. r=mstange

Comment 4

5 months ago
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/77fa43334879
Hook up invalidation testing in WebRender. r=mstange

Comment 5

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3cf0bec611e1
https://hg.mozilla.org/mozilla-central/rev/77fa43334879
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.