1452487 - WebDriver:{ExecuteScript,ExecuteAsyncScript}: Remove directInject parameter

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P3)

Description

[Andreas Tolfsen ❲:ato❳]

The WebDriver:ExecuteScript and WebDriver:ExecuteAsyncScript commands
used to have a directInject parameter and although this is supported
in evaluate.sandbox, it is no longer recognised as a valid input
parameter to GeckoDriver#execute_, even though it is listed in the
API documentation.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Bug 1452487 - Remove directInject functionality in evaluate.sandbox.

The evaluate.sandbox function accepts a directInject argument,
which is a relic from Marionette's B2G past when it did not support
evaluating scripts with lasting side-effects.

The API documentation in GeckoDriver#execute_ mentions directInject as a
valid parameter, but it is not picked up or passed on to evaluate.sandbox.
This effectively means the directInject functionality is unused.

Review commit: https://reviewboard.mozilla.org/r/234772/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/234772/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8966048 [details]
Bug 1452487 - Remove directInject functionality in evaluate.sandbox.

https://reviewboard.mozilla.org/r/234772/#review241208

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/feda10ec46db
Remove directInject functionality in evaluate.sandbox. r=maja_zf

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/feda10ec46db