Closed
Bug 1452522
Opened 6 years ago
Closed 6 years ago
Intermittent mathml/font-inflation-1.html == mathml/font-inflation-1-ref.html | image comparison, max difference: 255, number of differing pixels: 220
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: jmaher)
References
Details
(Keywords: intermittent-failure, Whiteboard: [retriggered][stockwell disabled])
Attachments
(1 file)
1.45 KB,
patch
|
kats
:
review+
|
Details | Diff | Splinter Review |
Filed by: csabou [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=172584526&repo=mozilla-central https://queue.taskcluster.net/v1/task/Js5x0NzpTKq-ZBywSwDByA/runs/0/artifacts/public/logs/live_backing.log https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/Js5x0NzpTKq-ZBywSwDByA/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
Comment hidden (Intermittent Failures Robot) |
Updated•6 years ago
|
Component: MathML → Graphics: WebRender
Assignee | ||
Comment 2•6 years ago
|
||
we have gone back in history to try to find the root cause here and we fail ~5% of the time: https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=windows10-64-qr%20debug-reftest-e10s-&fromchange=96426862f7afc9b93b2df493a4ea7c9d92ff213e&tochange=a41976b9334f3fb85ed6cb23888e4d543188bfb3&selectedJob=172915063 not sure if there is a root cause to point out, maybe there are other ways to fix this intermittent.
Whiteboard: [retriggered]
Comment 3•6 years ago
|
||
There is likely not a root cause; the windows-qr reftests were only enabled recently, shortly before the range you point out, in bug 1344350. Most likely it's been intermittent since then, but just not frequent enough for me to notice during my try pushes and the first few autoland runs.
Updated•6 years ago
|
Blocks: stage-wr-trains
Comment hidden (Intermittent Failures Robot) |
Comment 5•6 years ago
|
||
Alexis, thoughts on this? Should I just fuzz it? Here's a sample reftest analyzer link: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/LNJg9V-RSX21ABEzelyn6A/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
Flags: needinfo?(a.beingessner)
Comment 6•6 years ago
|
||
The difference is unsettling, but I think we can just fuzz it and move on with more important issues.
Flags: needinfo?(a.beingessner)
Assignee | ||
Comment 7•6 years ago
|
||
Attachment #8968232 -
Flags: review?(bugmail)
Comment 8•6 years ago
|
||
Comment on attachment 8968232 [details] [diff] [review] add fuzzy-if for webrender Review of attachment 8968232 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/reftests/mathml/reftest.list @@ +367,5 @@ > == mfrac-D-3.html mfrac-D-3-ref.html > == mfrac-D-4.html mfrac-D-4-ref.html > == mfrac-E-1.html mfrac-E-1-ref.html > test-pref(dom.webcomponents.shadowdom.enabled,true) == shadow-dom-1.html shadow-dom-1-ref.html > +pref(dom.meta-viewport.enabled,true) pref(font.size.inflation.emPerLine,25) fuzzy-if(webrender, 255, 220) == font-inflation-1.html font-inflation-1-ref.html I'd prefer to do fuzzy-if(webrender&&winWidget,0-255,0-220) so that it's specific to windows, and the explicit ranges make it more clear it's intermittent. (also note, spaces are not allowed inside an annotation) r+ with that
Attachment #8968232 -
Flags: review?(bugmail) → review+
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7042561b82de add fuzzy-if to mathml/font-inflation-1.html for webrender given high frequency intermittent failures. r=kats
Assignee | ||
Updated•6 years ago
|
Whiteboard: [retriggered][stockwell needswork:owner] → [retriggered][stockwell disabled]
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7042561b82de
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
Assignee: nobody → jmaher
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•