Closed Bug 1452604 Opened 2 years ago Closed 2 years ago

Apply Meta CSP to Content Privileged about:blocked

Categories

(Core :: DOM: Security, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox61 --- wontfix
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: vinoth, Assigned: vinoth)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

No description provided.
Blocks: 1436808
No longer depends on: 1436808
Blocks: 1449872
No longer blocks: 1436808
Attachment #8966189 - Flags: review?(ckerschb)
Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked

Christoph Kerschbaumer [:ckerschb] has approved the revision.

https://phabricator.services.mozilla.com/D880
Attachment #8966189 - Flags: review+
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
See Also: → 1452908
Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked

Phabricator failed to update the flag. Hence cancelling this.
Attachment #8966189 - Flags: review?(ckerschb)
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5415b0216c7
Meta CSP applied to content privileged about:blocked. r=ckerschb
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b5415b0216c7
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Depends on: 1465017
Backed out for causing bug 1465017.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a7562fe4671
https://hg.mozilla.org/releases/mozilla-beta/rev/857f7a31e7b3
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla61 → ---
Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked

I made changes to the previous patch and now fixed the issue in Bug 1465017.

Previously the "See Details" button was not working because of the below line,

document.getElementById("seeDetailsButton").onclick = onClickSeeDetails();

Now I added "addEventListener" instead of it and now it is working. I also rebased the previous patch to reflect new changes.

Please review the patch by enabling "Whitespace changes ignore all" in History tab of phabricator, to see the new changes I added clearly.
Or use the URL like this,
https://phabricator.services.mozilla.com/D880?whitespace=ignore-all
Attachment #8966189 - Flags: review?(gijskruitbosch+bugs)
Attachment #8966189 - Flags: review?(gijskruitbosch+bugs) → review-
Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked

:Gijs (he/him) has approved the revision.

https://phabricator.services.mozilla.com/D880
Attachment #8966189 - Flags: review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b26a5fa5e75f
Meta CSP applied to content privileged about:blocked r=Gijs,ckerschb
(In reply to Phabricator Automation from comment #8)
> Comment on attachment 8966189 [details]
> Bug 1452604 - Meta CSP applied to content privileged about:blocked
> 
> :Gijs (he/him) has approved the revision.
> 
> https://phabricator.services.mozilla.com/D880

Thanks for the quick review and landing it.
Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked

Got r+, hence removing the old r-.
Attachment #8966189 - Flags: review-
https://hg.mozilla.org/mozilla-central/rev/b26a5fa5e75f
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.