1452604 - Apply Meta CSP to Content Privileged about:blocked

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P2)

Comment 1

[Phabricator Automation]

Attachment: Bug 1452604 - Meta CSP applied to content privileged about:blocked

Comment 2

[Phabricator Automation]

Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked

Christoph Kerschbaumer [:ckerschb] has approved the revision.

https://phabricator.services.mozilla.com/D880

Comment 3

[Vinothkumar Nagasayanan [:vinoth]]

Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked

Phabricator failed to update the flag. Hence cancelling this.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5415b0216c7
Meta CSP applied to content privileged about:blocked. r=ckerschb

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b5415b0216c7

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing bug 1465017.

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a7562fe4671
https://hg.mozilla.org/releases/mozilla-beta/rev/857f7a31e7b3

Comment 7

[Vinothkumar Nagasayanan [:vinoth]]

Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked

I made changes to the previous patch and now fixed the issue in Bug 1465017.

Previously the "See Details" button was not working because of the below line,

document.getElementById("seeDetailsButton").onclick = onClickSeeDetails();

Now I added "addEventListener" instead of it and now it is working. I also rebased the previous patch to reflect new changes.

Please review the patch by enabling "Whitespace changes ignore all" in History tab of phabricator, to see the new changes I added clearly.
Or use the URL like this,
https://phabricator.services.mozilla.com/D880?whitespace=ignore-all

Comment 8

[Phabricator Automation]

Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked

:Gijs (he/him) has approved the revision.

https://phabricator.services.mozilla.com/D880

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b26a5fa5e75f
Meta CSP applied to content privileged about:blocked r=Gijs,ckerschb

Comment 10

[Vinothkumar Nagasayanan [:vinoth]]

(In reply to Phabricator Automation from comment #8)
> Comment on attachment 8966189 [details]
> Bug 1452604 - Meta CSP applied to content privileged about:blocked
> 
> :Gijs (he/him) has approved the revision.
> 
> https://phabricator.services.mozilla.com/D880

Thanks for the quick review and landing it.

Comment 11

[Vinothkumar Nagasayanan [:vinoth]]

Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked

Got r+, hence removing the old r-.

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b26a5fa5e75f

Comment 13

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b26a5fa5e75f