Closed
Bug 1452604
Opened 7 years ago
Closed 6 years ago
Apply Meta CSP to Content Privileged about:blocked
Categories
(Core :: DOM: Security, defect, P2)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla63
People
(Reporter: vinoth, Assigned: vinoth)
References
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Comment 1•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8966189 -
Flags: review?(ckerschb)
Comment 2•7 years ago
|
||
Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked
Christoph Kerschbaumer [:ckerschb] has approved the revision.
https://phabricator.services.mozilla.com/D880
Attachment #8966189 -
Flags: review+
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
Assignee | ||
Comment 3•7 years ago
|
||
Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked
Phabricator failed to update the flag. Hence cancelling this.
Attachment #8966189 -
Flags: review?(ckerschb)
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5415b0216c7
Meta CSP applied to content privileged about:blocked. r=ckerschb
Keywords: checkin-needed
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Comment 6•7 years ago
|
||
Backed out for causing bug 1465017.
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a7562fe4671
https://hg.mozilla.org/releases/mozilla-beta/rev/857f7a31e7b3
Status: RESOLVED → REOPENED
status-firefox62:
--- → affected
Resolution: FIXED → ---
Target Milestone: mozilla61 → ---
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked
I made changes to the previous patch and now fixed the issue in Bug 1465017.
Previously the "See Details" button was not working because of the below line,
document.getElementById("seeDetailsButton").onclick = onClickSeeDetails();
Now I added "addEventListener" instead of it and now it is working. I also rebased the previous patch to reflect new changes.
Please review the patch by enabling "Whitespace changes ignore all" in History tab of phabricator, to see the new changes I added clearly.
Or use the URL like this,
https://phabricator.services.mozilla.com/D880?whitespace=ignore-all
Attachment #8966189 -
Flags: review?(gijskruitbosch+bugs)
Updated•6 years ago
|
Attachment #8966189 -
Flags: review?(gijskruitbosch+bugs) → review-
Comment 8•6 years ago
|
||
Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked
:Gijs (he/him) has approved the revision.
https://phabricator.services.mozilla.com/D880
Attachment #8966189 -
Flags: review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b26a5fa5e75f
Meta CSP applied to content privileged about:blocked r=Gijs,ckerschb
Assignee | ||
Comment 10•6 years ago
|
||
(In reply to Phabricator Automation from comment #8)
> Comment on attachment 8966189 [details]
> Bug 1452604 - Meta CSP applied to content privileged about:blocked
>
> :Gijs (he/him) has approved the revision.
>
> https://phabricator.services.mozilla.com/D880
Thanks for the quick review and landing it.
Assignee | ||
Comment 11•6 years ago
|
||
Comment on attachment 8966189 [details]
Bug 1452604 - Meta CSP applied to content privileged about:blocked
Got r+, hence removing the old r-.
Attachment #8966189 -
Flags: review-
Comment 12•6 years ago
|
||
bugherder |
Status: REOPENED → RESOLVED
Closed: 7 years ago → 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Comment 13•6 years ago
|
||
bugherder |
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•