Closed Bug 1452621 Opened 3 years ago Closed 3 years ago

Cleanup some tag queries related code

Categories

(Toolkit :: Places, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

I found a few code lines that could be simplified considered the direction we are taking.
For example, most of the exceptions in serializeNode are not really that useful.
Attachment #8966222 - Flags: review?(standard8)
So what actually happens is that with my change Properties would be disabled on the roots, because the virtual roots have a concreteId but not an id. It may even be ok, there's no much point in opening the read-only properties dialog of a root.
Though, I must figure out what to do of the mochitest-browser that checks first if Properties is enabled. Probably the test should use the Library pane instead to check readonly.
Comment on attachment 8966222 [details]
Bug 1452621 - Cleanup some tag queries related code.

https://reviewboard.mozilla.org/r/234976/#review240980

Yay, especially nice to get rid of the grandParentId code, and to simplify serializeNode in general.
Attachment #8966222 - Flags: review?(standard8) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/5b9d9f133bee
Cleanup some tag queries related code. r=standard8
https://hg.mozilla.org/mozilla-central/rev/5b9d9f133bee
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Depends on: 1453545
You need to log in before you can comment on or make changes to this bug.