1452636 - Add Lando API Repo Configuration for Transplant dev "test-repo"

Status: RESOLVED FIXED

(Conduit :: Lando, enhancement)

Description

[Steven MacLeod [:smacleod]]

To support landing in the dev environment the transplant dev's "test-repo" must be configured in Lando.

Comment 1

[Phabricator Automation]

Attachment: repos: make repo configuration per environment (Bug 1452636).

We don't really want the same repositories enabled in dev/stage/prod so
now they are configured per environment. We only have two environments
configured for now, 'devsvcdev' and 'devscvprod', which correspond to
the value of 'ENV' in the dev and prod cloud services environments.

The 'phabricator-qa-dev' repository has been removed from Lando's
configuration as it is not configured in dev Transplant.

As part of this change repository and repository configuration existence
checks have been made part of the LandingAssessment. This should improve
the UX around visiting revision's with unsuported repositories in Lando.

Comment 2

[Phabricator Automation]

Comment on attachment 8966279 [details]
repos: make repo configuration per environment (Bug 1452636).

Byron Jones ‹:glob› has approved the revision.

https://phabricator.services.mozilla.com/D888

Comment 3

[Phabricator Automation]

Attachment: landings: stop double-blocking on repo-less revisions (Bug 1452636).

Revision's without a repo association were causing two landing blockers
to be generated. Returning both a blocker for no repo, and the repo not
being enabled in Lando is confusing. We now only return a single blocker
in this case.

Comment 4

[Steven MacLeod [:smacleod]]

Re-opening to fixup a small issue which manifests with the first change.

Comment 5

[Phabricator Automation]

Comment on attachment 8967146 [details]
landings: stop double-blocking on repo-less revisions (Bug 1452636).

Byron Jones ‹:glob› has approved the revision.

https://phabricator.services.mozilla.com/D917