1452658 - Sort windows QR reftest failures into real failures vs fuzzies

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

To get bug 1344350 landed sooner I did a blanket fails-if on any windows-qr reftest that was showing up as UNEXPECTED-FAIL. However a lot of those can actually be fuzzed. This bug is to go through the failures and triage them, and fuzz anything that can be fuzzed.

Here's a try push with all the fails-if(webrender&&winWidget) annotations removed, which should have the failures that need triaging:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fded4beb1dd337c9bae6ffbc8c2cd105bd54500f

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I triaged all the failures. The majority of them can be fuzzed as there is no real visible difference. There was one class of failures remaining, where it looks like we don't support -moz-crisp-edges properly. And some off-by-one/rounding problems.

Here's a try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a4ab5d6af50cdc8fc0082127d8479c3ac10b6bf

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Had to tweak a couple more, this one should be green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=52a5faca9b373f4d86666f5c16897e0d3c60bd76

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1452658 - Mark many reftests as fuzzy instead of failing for windows-qr.

Review commit: https://reviewboard.mozilla.org/r/235448/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235448/

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8966766 [details]
Bug 1452658 - Mark many reftests as fuzzy instead of failing for windows-qr.

https://reviewboard.mozilla.org/r/235448/#review241140

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c0e8f1f335f
Mark many reftests as fuzzy instead of failing for windows-qr. r=jrmuizel

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/1c0e8f1f335f