Closed Bug 1452658 Opened 2 years ago Closed 2 years ago

Sort windows QR reftest failures into real failures vs fuzzies

Categories

(Core :: Graphics: WebRender, defect, P3)

Other Branch
defect

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: kats, Assigned: kats)

References

(Blocks 1 open bug)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

To get bug 1344350 landed sooner I did a blanket fails-if on any windows-qr reftest that was showing up as UNEXPECTED-FAIL. However a lot of those can actually be fuzzed. This bug is to go through the failures and triage them, and fuzz anything that can be fuzzed.

Here's a try push with all the fails-if(webrender&&winWidget) annotations removed, which should have the failures that need triaging:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fded4beb1dd337c9bae6ffbc8c2cd105bd54500f
I triaged all the failures. The majority of them can be fuzzed as there is no real visible difference. There was one class of failures remaining, where it looks like we don't support -moz-crisp-edges properly. And some off-by-one/rounding problems.

Here's a try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a4ab5d6af50cdc8fc0082127d8479c3ac10b6bf
Comment on attachment 8966766 [details]
Bug 1452658 - Mark many reftests as fuzzy instead of failing for windows-qr.

https://reviewboard.mozilla.org/r/235448/#review241140
Attachment #8966766 - Flags: review?(jmuizelaar) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1c0e8f1f335f
Mark many reftests as fuzzy instead of failing for windows-qr. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/1c0e8f1f335f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.