1452678 - Use devtools/shared/link everywhere where we open links in a tab

Status: NEW

(DevTools :: General, enhancement, P3)

Description

[Alexandre Poirot [:ochameau]]

Bug 1444301 just introduced an helper module to easily open a link:
https://searchfox.org/mozilla-central/source/devtools/client/shared/link.js

Which can be used like this:
  const {openLink} = require("devtools/client/shared/link");
  ...
  openLink("https://developer.mozilla.org/docs/Tools", toolbox);

The dependency on toolbox object may be dropped per bug 1444301 comment 74.

Today, there is about 20 occurences where we manually call openUILink:
  https://searchfox.org/mozilla-central/search?q=openUILinkIn(&case=false&regexp=false&path=devtools

Comment 1

[Julian Descottes [:jdescottes]]

After Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1374741, 

they were all renamed to openWebLinkIn https://searchfox.org/mozilla-central/search?q=openWebLinkIn&case=false&regexp=false&path=devtools

(but sadly devtools/client/shared/link must have missed the migration patch)

Comment 2

[Julian Descottes [:jdescottes]]

And openTrustedLink as well.
https://searchfox.org/mozilla-central/search?q=openWebLinkIn&case=false&regexp=false&path=devtools

Should we complexify the module to handle both? And to support the relatedToCurrent argument (which allows to open a new tab next to the current tab instead of as the last one)

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Probably worth exposing both openWebLink and openTrustedLink versions, to match the underlying browser APIs.  The main benefit of this link module to me is centralizing the boilerplate to find these functions from a DevTools context.

(Could also add relatedToCurrent if we have a need for it.)

Comment 4

[Greg Tatum [:gregtatum]]

Looks like it broke already.

Comment 5

[Greg Tatum [:gregtatum]]

Sorry, see Bug 1453495

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(Bug 1453423 is handling the immediate breakage here, hopefully landing soon.)

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Julian, is this work completed?

I don't see any usage of openUILinkIn (only in a few comments)
https://searchfox.org/mozilla-central/search?q=openUILinkIn&path=devtools

Honza

Comment 8

[Julian Descottes [:jdescottes]]

The methods have been renamed: https://searchfox.org/mozilla-central/search?q=open.*LinkIn%5C%28&path=devtools&case=false&regexp=true

Comment 9

[Birhanie Beardsley]

Attachment: verreletab19823543.txt

Thanks from annsukhalsu1984.