Closed
Bug 1452741
Opened 6 years ago
Closed 6 years ago
Stop using the no-arg DOMEventTargetHelper constructor from MediaTrack
Categories
(Core :: Audio/Video: Playback, enhancement, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
13.98 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•6 years ago
|
||
MozReview-Commit-ID: AbE3XJdj4KO
Attachment #8966465 -
Flags: review?(bkelly)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8966465 [details] [diff] [review] Stop using the no-arg DOMEventTargetHelper constructor in MediaTrack Review of attachment 8966465 [details] [diff] [review]: ----------------------------------------------------------------- This looks reasonable. My only thought is if it would be nicer to pass around nsIGlobalObject instead of nsPIDOMWindowInner. It would be nice to move away from window-specific code where possible. We can burn that bridge in the future, though.
Attachment #8966465 -
Flags: review?(bkelly) → review+
|
|
Assignee | |
Comment 3•6 years ago
|
||
I can just switch all this stuff over to GetOwnerGlobal(). It's simple to do. I'll do it before landing and make sure it compiles.
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a0710c21795a Stop using the no-arg DOMEventTargetHelper constructor in MediaTrack. r=bkelly
|
||
Updated•6 years ago
|
Rank: 10
Component: Audio/Video → Audio/Video: Playback
Priority: -- → P2
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a0710c21795a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
|
|
Assignee | |
Updated•6 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•