Closed Bug 1452785 Opened Last year Closed Last year

[lij] Search engine setup for Firefox Mobile for Ligurian

Categories

(Mozilla Localizations :: lij / Ligurian, enhancement)

enhancement
Not set

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: delphine, Assigned: delphine)

References

()

Details

(Keywords: productization)

Attachments

(2 files)

We want to ship Firefox Mobile with a good list of search engines for Ligurian. 

I see there's actually already one set up for mobile: https://hg.mozilla.org/mozilla-central/file/default/mobile/locales/search/list.json#l455

Should we continue with this one, or is there one more suitable you'd like to go with? Seems like the one for Browser differs: https://hg.mozilla.org/mozilla-central/file/default/browser/locales/search/list.json#l492

We could mirror what there is in browser if you prefer (I don't think we do e-bay on mobile though).
Assignee: nobody → lebedel.delphine
I'm again i think that we can use the browser search engine removing this 2: ddg", "ebay-it".
So can use this one:

 "lij": {
      "default": {
        "visibleDefaultEngines": [
          "google", "bing", "amazon-it", "paroledigenova-lij", "wikipedia-lij"
        ]
      }
Ok I'll have to work on an icon then for paroledigenova-lij, so it will take me longer than I thought (and not sure if I can get to that this week).
I looked into creating the icon as per documentation we have, and it's more complicated that I thought it would be. I may just add all the other search engines in the meantime, because this is taking too long.
I'll poke in more to the icon work, and will let you know.
Hi,
I think we could remove paroledigenova-lij. It's not so important to have that search engine.
Oh well that makes my life so much easier then :) 
I'll go ahead and work on setting the rest up, then. If ever you change your mind, feel free to let me know, and I'll gladly take more time to add it.
Attached patch bug1452785.patchSplinter Review
Updated region.properties
Attachment #8971433 - Flags: review?(francesco.lodolo)
Attachment #8971433 - Flags: review?(francesco.lodolo) → review+
Comment on attachment 8971429 [details]
Bug 1452785 - [lij] Search engine setup for Firefox Mobile in Ligurian,

https://reviewboard.mozilla.org/r/240178/#review246044

Looks good. I'll file a couple of follow ups, since Amazon searchplugins are all over the place, and I'm not sure we need the search activity in Wikipedia.
Attachment #8971429 - Flags: review?(francesco.lodolo) → review+
(In reply to Delphine Lebédel [:delphine - use Need Info] from comment #8)
> Created attachment 8971433 [details] [diff] [review]
> bug1452785.patch
> 
> Updated region.properties

Landed in
https://hg.mozilla.org/l10n-central/lij/rev/b47556d7f68f696828756b66be886d08ffddb43f
Pushed by francesco.lodolo@mozillaitalia.org:
https://hg.mozilla.org/integration/autoland/rev/2d813a44c44c
[lij] Search engine setup for Firefox Mobile in Ligurian, r=flod
https://hg.mozilla.org/mozilla-central/rev/2d813a44c44c
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.