1452785 - [lij] Search engine setup for Firefox Mobile for Ligurian

Status: RESOLVED FIXED

(Mozilla Localizations :: lij / Ligurian, enhancement)

Description

[Delphine Lebédel [:delphine - use need info]]

We want to ship Firefox Mobile with a good list of search engines for Ligurian. 

I see there's actually already one set up for mobile: https://hg.mozilla.org/mozilla-central/file/default/mobile/locales/search/list.json#l455

Should we continue with this one, or is there one more suitable you'd like to go with? Seems like the one for Browser differs: https://hg.mozilla.org/mozilla-central/file/default/browser/locales/search/list.json#l492

We could mirror what there is in browser if you prefer (I don't think we do e-bay on mobile though).

Comment 1

[alessio]

Hi ,
We Can continue with this https://hg.mozilla.org/mozilla-central/file/default/browser/locales/search/list.json#l492

Comment 2

[alessio]

I'm again i think that we can use the browser search engine removing this 2: ddg", "ebay-it".
So can use this one:

 "lij": {
      "default": {
        "visibleDefaultEngines": [
          "google", "bing", "amazon-it", "paroledigenova-lij", "wikipedia-lij"
        ]
      }

Comment 3

[Delphine Lebédel [:delphine - use need info]]

Ok I'll have to work on an icon then for paroledigenova-lij, so it will take me longer than I thought (and not sure if I can get to that this week).

Comment 4

[Delphine Lebédel [:delphine - use need info]]

I looked into creating the icon as per documentation we have, and it's more complicated that I thought it would be. I may just add all the other search engines in the meantime, because this is taking too long.
I'll poke in more to the icon work, and will let you know.

Comment 5

[alessio]

Hi,
I think we could remove paroledigenova-lij. It's not so important to have that search engine.

Comment 6

[Delphine Lebédel [:delphine - use need info]]

Oh well that makes my life so much easier then :) 
I'll go ahead and work on setting the rest up, then. If ever you change your mind, feel free to let me know, and I'll gladly take more time to add it.

Comment 7

[Delphine Lebédel [:delphine - use need info]]

Attachment: Bug 1452785 - [lij] Search engine setup for Firefox Mobile in Ligurian,

Review commit: https://reviewboard.mozilla.org/r/240178/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240178/

Comment 8

[Delphine Lebédel [:delphine - use need info]]

Attachment: bug1452785.patch

Updated region.properties

Comment 9

[Francesco Lodolo [:flod]]

Comment on attachment 8971429 [details]
Bug 1452785 - [lij] Search engine setup for Firefox Mobile in Ligurian,

https://reviewboard.mozilla.org/r/240178/#review246044

Looks good. I'll file a couple of follow ups, since Amazon searchplugins are all over the place, and I'm not sure we need the search activity in Wikipedia.

Comment 10

[Francesco Lodolo [:flod]]

(In reply to Delphine Lebédel [:delphine - use Need Info] from comment #8)
> Created attachment 8971433 [details] [diff] [review]
> bug1452785.patch
> 
> Updated region.properties

Landed in
https://hg.mozilla.org/l10n-central/lij/rev/b47556d7f68f696828756b66be886d08ffddb43f

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d813a44c44c
[lij] Search engine setup for Firefox Mobile in Ligurian, r=flod

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2d813a44c44c