1452798 - JS error reports are missing stacks

Status: NEW

(Firefox :: General, defect, P3)

Description

[Osmose [:osmose, :mkelly]]

From the latest nightly, here's a sampling of the most frequent errors that don't have stack traces:

https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/2045985/
https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/2046040/
https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/2046767/
https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/2066010/
https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/2070966/
https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/2045118/

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

When I try to access these links I get "The project you were looking for was not found.". Any idea why?

Comment 2

[Osmose [:osmose, :mkelly]]

(In reply to Panos Astithas [:past] (please ni?) from comment #1)
> When I try to access these links I get "The project you were looking for was
> not found.". Any idea why?

You have an account now but it hasn't been granted access to the proper team in Sentry yet (Sentry has an issue where we cannot add someone to a team until after they've accepted an invite and created an account). Once you're granted access to the team they should be visible.

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

It's confusing that these pages don't at least display the single stack frame, but I've gone through the raw JSON and copied them below:

> https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/2045985/
"resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/highlighters/auto-refresh.js"

> https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/2046040/
"resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/tab.js"

> https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/2046767/
"resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/highlighters/auto-refresh.js"

> https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/2066010/
"jar:file:///C:/Program%20Files/Firefox%20Nightly/browser/omni.ja!/components/nsBrowserGlue.js"

> https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/2070966/
"resource://devtools/shared/base-loader.js -> resource://devtools/server/actors/tab.js"

> https://sentry.prod.mozaws.net/operations/nightly-js-errors/issues/2045118/
"resource://gre/modules/ExtensionParent.jsm"

Let's see if the JS team has any ideas.

Comment 4

[Nicolas B. Pierron [:nbp]]

Jason O., any idea what this might be? Could this be related to promises?

Jason L., many of these issues seems to be coming from the devtools, so maybe there is something which is more frequently done in devtools than elsewhere?

Comment 5

[Jason Laster [:jlast]]

Sorry, I'm not sure. Alex and jryans, would have a better idea of some of the server loader complexities

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

It looks like the issue is that we only keep stacks for errors that occur in windows[1] because the console service apparently relies on the window ID clear out console messages[2].

With DevTools code loaded through our loader, the scripts are running in a sandbox, so there is no associated window ID, which leads to the stack info being dropped.

In order to resolve this, I guess we would need to find some way to identify sandboxes and track them when they go away so that the console service can clean up any related logs similar to what is done for windows.  With that in place, we should be able to relax the window ID check so that stacks can be kept for sandboxes as well.

As far as DevTools impact, it seems that both the client and server are affected if the loader is used.

[1]: https://searchfox.org/mozilla-central/rev/eb51d734a8c06ac5973291be9bcc74ed4e999bca/js/xpconnect/src/nsXPConnect.cpp#337
[2]: https://searchfox.org/mozilla-central/rev/eb51d734a8c06ac5973291be9bcc74ed4e999bca/xpcom/base/nsConsoleService.cpp#494

Comment 7

[Alexandre Poirot [:ochameau]]

How are your collecting stack traces? Via console service?

You may be hitting bug 1237904 (it has been closed because of FirefoxOS triage, but this bug isn't specific to fxos).
The stacks may be empty, but you should still be able to access to error file/line.
It will be empty for anything that isn't from a document/window, so: JSMs, XPCOMs, frame scripts, sandboxes, ...

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Alexandre Poirot [:ochameau] from comment #7)
> You may be hitting bug 1237904 (it has been closed because of FirefoxOS
> triage, but this bug isn't specific to fxos).

Thanks Alex, it does seem related.  I reopened that bug.

Comment 9

[Osmose [:osmose, :mkelly]]

(In reply to Alexandre Poirot [:ochameau] from comment #7)
> How are your collecting stack traces? Via console service?

Yup: https://searchfox.org/mozilla-central/source/browser/modules/BrowserErrorReporter.jsm#91

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(Moving this bug to track the issue for the JS error reports project, which seems to sometimes use Socorro :: General.  Bug 1237904 covers the platform issue that's dropping the stacks.)

Comment 11

[Osmose [:osmose, :mkelly]]

Moving to Firefox since it's the more appropriate product, and marking as P3 for the backlog.

Comment 12

[Osmose [:osmose, :mkelly]]

The Sentry project linked in comments above is going away soon, but the issue of dropping stacks for certain errors is still relevant IMO, so I'm leaving this open.