1452852 - layout.css.text-align-unsafe-value.enabled is not effective

Status: RESOLVED DUPLICATE of bug 1388949

(Core :: CSS Parsing and Computation, enhancement)

Description

[Xidorn Quan [:xidorn] UTC+11]

We didn't implement text-align: unsafe in Stylo, and thus layout.css.text-align-unsafe-value.enabled is basically useless now.

We had bug 1388949 open for implementing it, but as far as I can see, it is not part of any spec right now, and I don't see any layout code using the result either. We should probably just remove this pref as well as related code.

Comment 1

[Cameron McCormack (:heycam)]

CC Mats who implemented true/unsafe.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I think it's intended to be introduced by https://drafts.csswg.org/css-align/#overflow-values , it's just that spec doesn't actually include 'text-align'.  But if we actually don't have layout code implementing it then I guess removing the pref would make sense, but it is something we should think about doing eventually, IMO.

Comment 3

[Xidorn Quan [:xidorn] UTC+11]

(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #0)
> I don't see any layout code using the result either.

I was wrong on this. nsStyleText has mTextAlignTrue and mTextAlignLastTrue which are probably for this. I didn't see anything referencing the keyword so I thought it was not implemented, but apparently they are.

Comment 4

[Xidorn Quan [:xidorn] UTC+11]

Given that we implemented it in the layout part, and dbaron thinks we should do this eventually, I guess I should just dupe it into the implementing bug...