Closed Bug 1452887 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 10364 - [css-typed-om] Fix unsupported values in non-list-valued properties.

Categories

(Core :: DOM: CSS Object Model, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10364 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10364
Details from upstream follow.

Darren Shen <shend@chromium.org> wrote:
>  [css-typed-om] Fix unsupported values in non-list-valued properties.
>  
>  Currently, when we reify a value, we try to first reify it as a single
>  value. If that fails, we try reifying it as a list value. This code
>  was written with the incorrect assumption that only list-valued
>  properties are stored as CSSValueLists. This is not true, as many single
>  valued properties (such as grid-auto-flow) are stored as CSSValueLists.
>  
>  This patch adds an additional check so that only properties that are
>  explicitly marked as list-valued are reified as list values.
>  
>  Bug: 829881
>  Change-Id: I965e38355b9859a43fcb1b940f19237f9f07fdf6
>  Reviewed-on: https://chromium-review.googlesource.com/1002214
>  Reviewed-by: Rune Lillesveen <futhark@chromium.org>
>  Commit-Queue: Darren Shen <shend@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#549455}
>  
>  
>
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Try push failed: decision task returned error
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6dbe2e0d97d1
[wpt PR 10364] - [css-typed-om] Fix unsupported values in non-list-valued properties., a=testonly
https://hg.mozilla.org/mozilla-central/rev/6dbe2e0d97d1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.