Closed
Bug 1452924
Opened 6 years ago
Closed 6 years ago
Duplicate notification of consumer condition variable after running GC parallel task
Categories
(Core :: JavaScript: GC, enhancement, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla61
| Tracking | Status | |
|---|---|---|
| firefox61 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
|
1.04 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
We currently notify the condition variable twice, once in GCParallelTask::runFromHelperThread and once in HelperThread::handleGCParallelWorkload which is its only caller.
|
Assignee | |
Updated•6 years ago
|
Priority: -- → P3
|
|
Assignee | |
Comment 1•6 years ago
|
||
Patch to remove the duplicate notification.
Attachment #8966556 -
Flags: review?(jdemooij)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8966556 [details] [diff] [review] bug1452924-duplicate-notify Review of attachment 8966556 [details] [diff] [review]: ----------------------------------------------------------------- Good find.
Attachment #8966556 -
Flags: review?(jdemooij) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8014105bae53 Remove duplicate condition variable notification after running parallel GC task r=jandem
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8014105bae53
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•