1452926 - Add back easing to the videocontrol control animation

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, enhancement)

Description

[:Gijs (he/him)]

I've just realized from some other comments - there was no timing function specified for the transition, so it used the default, which was "ease". AIUI the web animation stuff will just do a linear animation by default. We should add back easing.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1452926 - add easing back to videocontrol control animations,

Review commit: https://reviewboard.mozilla.org/r/235308/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235308/

Comment 2

[:Gijs (he/him)]

Of course, it turns out that it's a bit tricky to add it to the status overlay animation because of how the delay is encoded. Once we ship web animations everywhere, the easing will work and so would switching to a proper 'delay' property, which would then make it sensible to add easing there, too. Right now, the easing property should work on nightly+devedition and be ignored on beta/release because support is (at least according to MDN) behind the pref.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8966578 [details]
Bug 1452926 - add easing back to videocontrol control animations,

https://reviewboard.mozilla.org/r/235308/#review241202

According to https://www.w3.org/TR/css-transitions-1/#transition-timing-function-property and https://www.w3.org/TR/web-animations-1/#timing-functions, yes we need to set timing function to 'ease' explicitly here. Thank you for catching that!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d082bbf8687a
add easing back to videocontrol control animations, r=timdream

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d082bbf8687a