Closed Bug 1452967 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 10365 - [css-typed-om] Add support for fill & stroke properties.

Categories

(Core :: DOM: CSS Object Model, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10365 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10365
Details from upstream follow.

Darren Shen <shend@chromium.org> wrote:
>  [css-typed-om] Add support for fill & stroke properties.
>  
>  Some failures:
>  - fill & stroke shorthands do not seem to follow spec (it should be
>    list valued)
>  - fill-opacity & stroke-opacity do not clamp their values (ComputedStyle
>    should clamp values, like opacity).
>  - fill-color is not implemented.
>  
>  Bug: 820299
>  Change-Id: I0879e353cd22291aa8a34f2a10895809b43d8aa5
>  Reviewed-on: https://chromium-review.googlesource.com/998454
>  Reviewed-by: nainar <nainar@chromium.org>
>  Commit-Queue: Darren Shen <shend@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#549499}
>  
>  
>
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Ran 12 tests and 12 subtests
OK     : 12
FAIL   : 12

New tests that have failures or other problems:
/css/css-typed-om/the-stylepropertymap/properties/fill-color.html
    'fill-color' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/fill-opacity.html
    'fill-opacity' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/fill-rule.html
    'fill-rule' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/fill.html
    'fill' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/stroke-dasharray.html
    'stroke-dasharray' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/stroke-dashoffset.html
    'stroke-dashoffset' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/stroke-linecap.html
    'stroke-linecap' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/stroke-linejoin.html
    'stroke-linejoin' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/stroke-miterlimit.html
    'stroke-miterlimit' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/stroke-opacity.html
    'stroke-opacity' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/stroke-width.html
    'stroke-width' property: FAIL
/css/css-typed-om/the-stylepropertymap/properties/stroke.html
    'stroke' property: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/062a73352e12
[wpt PR 10365] - [css-typed-om] Add support for fill & stroke properties., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/5c94ad2ad926
[wpt PR 10365] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/062a73352e12
https://hg.mozilla.org/mozilla-central/rev/5c94ad2ad926
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.