Closed Bug 1453039 Opened 7 years ago Closed 6 years ago

[wpt-sync] Sync PR 10400 - [KeyboardLock] Updating API to reject the first promise if lock is called twice

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10400 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10400 Details from upstream follow. Joe Downing <joedow@chromium.org> wrote: > [KeyboardLock] Updating API to reject the first promise if lock is called twice > > Per the W3C spec, when navigator.keyboard.lock() is called a second time (or > more), any previous, pending promises should be rejected. The old behavior > of the API was to reject the newest promise which is not correct. > > As part of this cleanup, I am also using DomExceptions instead of raw strings > for the rejection. This allows us to clean up the test code (which fails if > a raw string is returned in the reject call). > > BUG=680809 > > Change-Id: Ic4f2563a6ccc22a434f8e6079f1995d9e584f9aa > Reviewed-on: https://chromium-review.googlesource.com/1003472 > WPT-Export-Revision: 0e1c522dfe1f220ff9e9366b5073db61e182d82d
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Ran 3 tests and 3 subtests OK : 3 FAIL : 3
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/7cd755133c0b [wpt PR 10400] - [KeyboardLock] Updating API to reject the first promise if lock is called twice, a=testonly
https://hg.mozilla.org/mozilla-central/rev/7cd755133c0b
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.