Closed
Bug 1453054
Opened 6 years ago
Closed 6 years ago
EdReplace.js has useless QI to nsIDOMNode
Categories
(MailNews Core :: Composition, enhancement)
MailNews Core
Composition
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 61.0
People
(Reporter: bzbarsky, Assigned: jorgk-bmo)
Details
Attachments
(1 file)
|
1.07 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
This one: var rootNode = gEditor.rootElement.QueryInterface(Ci.nsIDOMNode); This will likely stop working at some point (maybe even as part of bug 1453053).
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
Comment on attachment 8966702 [details] [diff] [review] 1453054-remove-qi.patch Forgot to set r?
Attachment #8966702 -
Flags: review?(bzbarsky)
|
Reporter | |
Comment 3•6 years ago
|
||
Comment on attachment 8966702 [details] [diff] [review] 1453054-remove-qi.patch r=me
Attachment #8966702 -
Flags: review?(bzbarsky) → review+
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/0e10269b8a3a Remove needless QI to nsIDOMNode in editor's EdReplace.js. r=bz
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•6 years ago
|
Component: General → Composition
Product: Composer → MailNews Core
Target Milestone: --- → Thunderbird 61.0
Version: other → unspecified
You need to log in
before you can comment on or make changes to this bug.
Description
•